Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making API of Literal types more intuitive. #203

Open
irina-dragoste opened this issue Mar 25, 2021 · 0 comments
Open

making API of Literal types more intuitive. #203

irina-dragoste opened this issue Mar 25, 2021 · 0 comments
Labels
documentation Related to helping others using Rulewerk

Comments

@irina-dragoste
Copy link
Collaborator

irina-dragoste commented Mar 25, 2021

Constructors of Literal types, as well of methods in Expressions utility class that construct literals use parameter name terms (of type some collection/array of Term objects) to refer to the literal arguments. This makes it tempting for the user to call getTerms() (which returns the set of terms used as arguments) instead of getArgumets() (the actual list of argument terms the literal was constructed with).

It would be useful to rename terms parameter to arguments in all these constructor methods.

@irina-dragoste irina-dragoste added the documentation Related to helping others using Rulewerk label Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Related to helping others using Rulewerk
Projects
None yet
Development

No branches or pull requests

1 participant