Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate VC Data Model Spec Test Suite Into SSI #166

Closed
Tracked by #168
LuisOsta opened this issue Nov 20, 2023 · 10 comments · Fixed by #167
Closed
Tracked by #168

Integrate VC Data Model Spec Test Suite Into SSI #166

LuisOsta opened this issue Nov 20, 2023 · 10 comments · Fixed by #167
Assignees
Labels
enhancement New feature or request

Comments

@LuisOsta
Copy link
Contributor

Should incorporate into GHA for automated testing, along with DIDs

@LuisOsta LuisOsta self-assigned this Nov 20, 2023
@LuisOsta LuisOsta changed the title Re run https://github.com/knox-networks/vc-test and highlight gaps Integrate VC Data Model Spec Test Suite Into SSI Nov 20, 2023
@LuisOsta
Copy link
Contributor Author

Link to our fork - https://github.com/knox-networks/vc-test-suite

@LuisOsta
Copy link
Contributor Author

LuisOsta commented Nov 22, 2023

I've filed w3c/vc-test-suite#135 to deal with the proof-related issues we were having due to us expecting certain properties to be part of any proof object. As a temporary solution I've copied the proof in example 5 to examples 1-4. This doesn't result in a logical change of what the examples are meant to test as far as I know

@LuisOsta
Copy link
Contributor Author

LuisOsta commented Nov 22, 2023

When you exclude the features, we don't support yet we've got 6 failures currently I've attached the report below

KnoxNetworks-report.json

@LuisOsta LuisOsta linked a pull request Nov 22, 2023 that will close this issue
@LuisOsta
Copy link
Contributor Author

LuisOsta commented Nov 23, 2023

One spec test remains failing and its the one that requires the verifiableCredential field to be optional, which to me is weird in concept but there's more information here - w3c/vc-test-suite#113. Should we file an issue with the VC spec to clarify the language?

@LuisOsta LuisOsta added the enhancement New feature or request label Nov 23, 2023
@LuisOsta
Copy link
Contributor Author

LuisOsta commented Nov 23, 2023

Here's an updated report

KnoxNetworks-report.json

@LuisOsta
Copy link
Contributor Author

I've fixed the last issue, the verifiableCredential issue is completely correct. Here's a link to the 1.1 spec - https://www.w3.org/TR/vc-data-model/#presentations-0. What remains is the proof-related issues - w3c/vc-test-suite#135

@LuisOsta
Copy link
Contributor Author

Our repo - https://github.com/knox-networks/vc-test-suite has updated the examples to not be malformed and added the Knox Networks report

@fkim7
Copy link
Collaborator

fkim7 commented Nov 29, 2023

Thanks- updated results can be found here https://knox-networks.github.io/vc-test-suite/implementations/

some comments
2.3 Credential Status - why do we show no support?
Credential Schema- I think we should be able to address this in the upcoming sprints as we add VC schema
ZKP- Would be interesting to see how the other providers with support passed the tests.

@fkim7
Copy link
Collaborator

fkim7 commented Nov 29, 2023

Image

@fkim7
Copy link
Collaborator

fkim7 commented Dec 12, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants