-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate VC Data Model Spec Test Suite Into SSI #166
Comments
Link to our fork - https://github.com/knox-networks/vc-test-suite |
I've filed w3c/vc-test-suite#135 to deal with the proof-related issues we were having due to us expecting certain properties to be part of any proof object. As a temporary solution I've copied the proof in example 5 to examples 1-4. This doesn't result in a logical change of what the examples are meant to test as far as I know |
When you exclude the features, we don't support yet we've got 6 failures currently I've attached the report below |
One spec test remains failing and its the one that requires the verifiableCredential field to be optional, which to me is weird in concept but there's more information here - w3c/vc-test-suite#113. Should we file an issue with the VC spec to clarify the language? |
Here's an updated report |
I've fixed the last issue, the |
Our repo - https://github.com/knox-networks/vc-test-suite has updated the examples to not be malformed and added the Knox Networks report |
Thanks- updated results can be found here https://knox-networks.github.io/vc-test-suite/implementations/ some comments |
Should incorporate into GHA for automated testing, along with DIDs
The text was updated successfully, but these errors were encountered: