clarify setup for static libraries #935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpallant
approved these changes
Feb 13, 2025
|
I appreciate you taking them time to improve our documentation to cover this usecase, and I apologise for our documentation previously being unclear in this area. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying the defmt linker args to a cargo package which produces a static lib does not yield any warning.
A user attempting to use this as a module of a larger C project may be surprised to not receive any logs.
After dealing with this issue myself I think its worth putting this into a somewhat prominent user guide section as the final binary gets built and the issue isn't immediately obvious.