Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test files from the npm package #89

Open
Havunen opened this issue Sep 17, 2024 · 2 comments
Open

Remove test files from the npm package #89

Havunen opened this issue Sep 17, 2024 · 2 comments
Labels

Comments

@Havunen
Copy link

Havunen commented Sep 17, 2024

F-Secure WithSecure security scanner does not like the test file and is reporting false positive about it.
Never the less, including the test file is waste of network traffic.

https://github.com/koajs/body-parsers/blob/master/test/test.js

@Havunen Havunen added the bug label Sep 17, 2024
@Havunen
Copy link
Author

Havunen commented Sep 17, 2024

The dependency chain seems to be following:

"koa-better-body": "^3.3.9",

Loads "koa-body-parsers": "tunnckocore/body-parsers#patch-1"

which seems to be hosted here:

https://github.com/tunnckoCore/body-parsers/tree/patch-1

and it contains a test file shipped in the npm package.

@tunnckoCore
Copy link
Contributor

Never the less, including the test file is waste of network traffic.

Valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants