Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run-app #2

Open
fedotxxl opened this issue Dec 27, 2012 · 5 comments
Open

run-app #2

fedotxxl opened this issue Dec 27, 2012 · 5 comments

Comments

@fedotxxl
Copy link

Hello. I'm trying to use your plugin to improve grails run-app performance by

/mnt/ntfs/job/improx/improxClient.sh run-app

but it looks like it doesn't work:
Intellij Idea console prints:

23:56:17.365 INFO [localhost].[/] Initializing Spring FrameworkServlet 'grails'
23:56:17.404 INFO http11.Http11Protocol Starting ProtocolHandler ["http-bio-8080"]
|Server running. Browse to http://localhost:8080/

but server is not alive. After run-app call Grails interactive console prints

| Enter| Goodbye

end exits from interactive mode

ps
test-app works ok

@nobeans
Copy link
Member

nobeans commented Dec 28, 2012

Thanks. I could reproduce the issue. I'll try to fix it later, perhaps after new-year holidays.

@nobeans
Copy link
Member

nobeans commented Feb 19, 2013

Sorry for late. I've tried to fix the issue, but it's more difficult than I thought.
Because a start-app command causes a new thread to monitor the use input on interactive mode.The issue seems to be caused by handleing the old thread.

To fix it, restructuring the whole architecture might be need.

So I won't fix it for the time being. sorry.

(FYI)
following commands also cannot be invoked via improx, because they are not implemented as a 'script' but as a special built-in command: create-app, install-plugin, uninstall-plugin, quit, stop-app, exit and !(shell command).

@nobeans
Copy link
Member

nobeans commented Feb 19, 2013

I think that the forked execution will provide us a workaround.
http://grails.io/post/43484836985/road-to-grails-2-3-forked-execution

@dadmin
Copy link

dadmin commented Feb 19, 2013

Ok, let's wait for 2.3. Could you check this bug when 2.3 will be released?

@nobeans
Copy link
Member

nobeans commented Feb 22, 2013

Sure. I'll check this on 2.3. so I keep this issue open.

We can also use a fork mode by uncommenting the followings line at BuildConfig.groovy even in 2.2.x.

// uncomment (and adjust settings) to fork the JVM to isolate classpaths
grails.project.fork = [
   run: [maxMemory:1024, minMemory:64, debug:false, maxPerm:256]
]

I tried it, then run-app/stop-app were succeed! But fork mode of 2.2 seems a little unstable yet; A very simple application works well, but another appolication having complex dependencies couldn't run app completely.

The important thing is that improx and interactive mode had kept alive after the operations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants