Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection Atomic Swaps #11331

Open
hassnian opened this issue Jan 3, 2025 · 2 comments
Open

Collection Atomic Swaps #11331

hassnian opened this issue Jan 3, 2025 · 2 comments
Assignees
Labels
A-atomic-swap A-offer issues related to offers chief design-request UX first Improvement for UX

Comments

@hassnian
Copy link
Contributor

hassnian commented Jan 3, 2025

Users should be able to create collection atomic-swaps

the main difference between this and other atomic-swaps is that the user has not selected adesiredItem inside the desiredCollection

so any owner of nfts in that desiredCollection can accept the atomic-swap

@exezbcz designs for creating and accepting these kind of swaps are needed

simplified requirements

Only a desiredCollection is needed and also

  • for swaps: offeredItem, surcharge
  • for offers: offer amount

how to create one

Swaps

maybe we have. button inside a collection that redirects to the swap landing page but step "2" (where the user selects the nft they want is skipped) , swap review step should accommodate for this

CleanShot 2025-01-03 at 15 07 22@2x

Offer

issue: #11116

maybe we have. button inside a collection that opens this modal without the nft section

how to accept one

Any owner of nfts in the desiredCollection of that atomic-swap can accept that trade and select a nft from any that they own

  • the user needs to be able to search and select a nft of that collection
  • then they are able to accept the trade
@exezbcz
Copy link
Member

exezbcz commented Jan 25, 2025

Image

this is how i am thinking about the collection offer and collection swap

the main improvements i think are needed on the incoming offers and swap table on the profile, otherwise it's two simple modals for each flow that reuses lot of components

@exezbcz
Copy link
Member

exezbcz commented Jan 25, 2025

i am not sure if we should anyhow use the swap UI we have now for review etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-atomic-swap A-offer issues related to offers chief design-request UX first Improvement for UX
Projects
Status: In Progress
Development

No branches or pull requests

2 participants