Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Livestream not working on 18.2-RC2 #9

Open
matejmosko opened this issue May 10, 2019 · 1 comment
Open

Livestream not working on 18.2-RC2 #9

matejmosko opened this issue May 10, 2019 · 1 comment

Comments

@matejmosko
Copy link
Contributor

matejmosko commented May 10, 2019

After update to 1.8.0 the livestream doesn't work on kodi 18.2-RC2 because the addon checks for the version of kodi as float. However "18.2-RC2" isn't float and cannot be compared to >=18.

Log here: https://paste.kodi.tv/covomupune

Problem clearly seen here:

ERROR: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                             - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                            Error Type: <type 'exceptions.ValueError'>
                                            Error Contents: invalid literal for float(): 18.2-RC1
                                            Traceback (most recent call last):
                                              File "/home/osmc/.kodi/addons/plugin.video.rtvs.sk/default.py", line 111, in <module>
                                                RtvsXBMCContentProvider(rtvs.RtvsContentProvider(tmp_dir=xbmc.translatePath(__addon__.getAddonInfo('profile'))), settings, __addon__).run(params)
                                              File "/home/osmc/.kodi/addons/script.module.stream.resolver/lib/contentprovider/xbmcprovider.py", line 87, in run
                                                return self.play({'url': params['play'], 'info': params})
                                              File "/home/osmc/.kodi/addons/plugin.video.rtvs.sk/default.py", line 41, in play
                                                stream = self.resolve(item['url'])
                                              File "/home/osmc/.kodi/addons/plugin.video.rtvs.sk/default.py", line 104, in resolve
                                                return self.provider.resolve(item, select_cb=select_cb)
                                              File "/home/osmc/.kodi/addons/plugin.video.rtvs.sk/resources/lib/rtvs.py", line 301, in resolve
                                                if is_kodi_leia():
                                              File "/home/osmc/.kodi/addons/plugin.video.rtvs.sk/resources/lib/rtvs.py", line 92, in is_kodi_leia
                                                if (float(version) >= 18):
                                            ValueError: invalid literal for float(): 18.2-RC1
                                            -->End of Python script error report<--
@matejmosko
Copy link
Contributor Author

Fix already in code. Version bump initiated for the change to be included #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant