-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 21.1.0 Stalker crashed on Windows #227
Comments
Could you create a full debug log capturing the crash please? |
I hope that is correct. |
Here are the 2 logs when I use a new installation and update from Stalker 21.0.1 to 21.1.0. The Version 21.0.1 works fine. |
Can you try two things? First try to install 21.0.1 of the addon and see if the crash goes away. Secondly, try deleting the |
Try installing the old version 21.0.0, disable automatic updates. That's what I did, and it works. |
This will make the addon functional but will not help figure out that the issue is. Out of interest, are you also on Windows? |
I installed new version on windows, it crashed and can't even add address and url. |
Is it only windows that has this problem? Has anyone uncovered issues on another platform? |
Is this a fresh install or an update on a previous version? |
Fresh install Kodi omega 21.0 and stalker client 21.1.0. When pvr client installed kodi crashed. |
stalker client 21.1.0 crash.On windows. |
Yes. When you install it kodi closes automatically. |
Can someone try on a non windows platform? If it doesn’t crash there might help narrow it down. |
Some test settings.xml files might also help for testing. |
So with 21.0.1 it works great. After an update to version 21.1.0, Kodi crashes immediately. The migration of the settings.xml is not even carried out. A notification appears in the top right that the Stalker Client has started and then causes Kodi to crash. In the test, all 5 providers were completely filled out and worked without problems. But regardless of whether it is an existing or new installation of Kodi, the behavior is the same. If I copy the contents of the 21.0.1.zip back into the "addons" folder after the crash, the client works again without problems. |
The settings.xml remains unchanged. I can use it again immediately after copying version 21.0.1 back in. In the log from line 706 I noticed that it is trying to read the settings.xml but it cannot find any content even though it is available. |
I have just tested version 21.1.0 again on Android TV. It works without any problems there |
Yes I am on Windows. But with my phone v21.1.0 works well. I think that it's only on Windows that it's crash. |
Thanks for confirming |
So there is no instance-settings-1.xml created? That likely means the crash is happening as part of the settings migration. I can create a testbuild for you to try with some extra logging to try and figure out where the crash occurs. |
Yes, exactly, no instance settings are created because the crash happens beforehand. |
Please try these testbuilds on windows and post a full debug log. If the crash is happening during migration you should see debug log entries starting with https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.stalker/detail/PR-229/1/artifacts |
Could not parse type "Setting.Details.SettingList" |
That’s an info log and a not a debug log so none of the new logging will be printed I’m afraid. Can you restart in debug mode and post another log please?
|
Check these two, it's in debug mode |
Your case appears to be different. If you look in |
|
Having the same isues on my Windows 10 ( 64bit and 32 bit ) installations ... the same config ( copyed the complete "portable_data" folder to each Windows ) works as expected on both of my Windows 11 configurations. |
Also, When the addon is installed it crashed. I can't provide url and mac address for it. In userdata\addon_data\ folder pvr.stalker is not there. No inputs is given. |
Yes. In Windows 11 it works fine. |
So I've now done 2 tests. 2nd test kodi_new_Install-PVR_Install_from_zip.log |
Thanks for the testing so far. The crash appears to happen after settings are loaded, maybe when authenticating. The strange thing is that it appears to load default settings and not do a migration, not sure why. I've added more logging, could you test again? New testbuilds: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.stalker/detail/PR-229/2/artifacts |
Tested in the same way as before. kodi_new_Install-PVR_Install_from_zip.log |
Brilliant, we are getting closer. Can you run the same test with these testbuilds?https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.stalker/detail/PR-229/3/artifacts |
Thanks again, closer still. More testbuilds: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.stalker/detail/PR-229/4/artifacts The builds should be there in a few minutes, just building now. |
Very strange. So it looks like the problem is with the mutex used for authentication, or the thread is blocked somewhere. I can try cleaning up that code a bit and/or fix what’s blocking it. Weird that it only causes a problem on windows. |
Do you still need the final tests from me? Or have you found the error now? |
Good for now thanks. I need to figure out where’s it’s blocking and add more logging. Will let you know when I have another build to test. |
Ok, one more set of testbuilds I need a debug log for: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.stalker/detail/PR-229/5/artifacts |
Thank you for your work. Just let us know if you want us to test something. |
No Problem. |
Here are the latest tests. kodi_new_Install-PVR_Install_from_zip.log |
Ok, first attempt at a fix. Testbuilds: https://jenkins.kodi.tv/blue/organizations/jenkins/kodi-pvr%2Fpvr.stalker/detail/PR-229/6/artifacts Will need a full debug log as usual. |
Ok, no change. I’m going to ask someone who develops on windows to try running it and see if they can find the cause of the crash. |
Can someone try this using the latest version of the add-on but instead a nightly version of kodi omega, on a non working windows device/PC? |
Works for KodiSetup-20240626-7508b879-Omega-x64 and pvr 21.1.0 |
Ok, then it looks like it might be a runtime issue. Can you revert to the released kodi version, and then run it to prove it crashes and if so, then try installing https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-170, to see if it goes away? It might be that the newer version of the addon is built with a newer runtime and systems with an older runtime then crash. |
Yes. It needs Microsoft Visual C++ Redistributable Version 14.40.33810.0 to run. |
Now it's working fine. |
I can confirm, this resolved the isue on x86/x64 Windows 10 installations ... even the newest version of "inputstream.adaptive" is working now ( probobly built with the same newer runtime ). Thank You! |
Excellent, thanks for all the testing! |
Now it's working fine 👌 Thank you @ALL |
@phunkyfish are changes required in the addon source to fix this problem? I am asking, because users reporting the same for pvr.waipu |
No changes required in the addon. Users can install the latest VC++ redistributable or use an Omega nightly of kodi. |
Pinned issue created for other users who come across this problem: #230 Also updated on forum post for v21.1.0: https://forum.kodi.tv/showthread.php?tid=377974&pid=3202625#pid3202625 |
Hello from Germany.
Since the update last night, Kodi keeps crashing shortly after starting.
It always freezes briefly when Stalker starts and then crashes.
It worked fine with the last version. A new installation of Kodi and Stalker produces the same result. When upgrading from Kodi 20.5 to 21.0, it works until the next Kodi restart, then Kodi also crashes when loading the client.
kodi.log
kodi_crashlog-21.0 Git_20240406-60c4500054-20240623-122122.dmp
kodi_stacktrace-21.0 Git_20240406-60c4500054-20240623-122122.txt
The text was updated successfully, but these errors were encountered: