Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Cache validation does not check latent size for SD/SDXL (sd3 branch) #1771

Open
feffy380 opened this issue Nov 7, 2024 · 0 comments
Open

Comments

@feffy380
Copy link
Contributor

feffy380 commented Nov 7, 2024

The new cache validation in the sd3 branch only checks the key name. When multiresolution is disabled (like with sd and sdxl training), the key is latents and the size of the tensor is not checked. If the training resolution or bucketing changes, the cache should not pass validation.

key_reso_suffix = f"_{expected_latents_size[0]}x{expected_latents_size[1]}" if multi_resolution else ""
try:
npz = np.load(npz_path)
if "latents" + key_reso_suffix not in npz:
return False

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant