Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postinstall hook flips out due to wavy symlink #6

Open
cdaringe opened this issue Apr 22, 2016 · 4 comments
Open

postinstall hook flips out due to wavy symlink #6

cdaringe opened this issue Apr 22, 2016 · 4 comments

Comments

@cdaringe
Copy link

cdaringe commented Apr 22, 2016

problem statement

  • post install scripts gets run infinite times due to wavy link

example

npm init && npm i --save wavy && [add some npmpostinstallscript] && npm i

watch her buck.

🛰  cdieringer:~/node/wavy-test$ npm i
npm WARN package.json [email protected] No description
npm WARN package.json [email protected] No repository field.
npm WARN package.json [email protected] No README data

> [email protected] postinstall /Users/cdieringer/node/wavy-test/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~
> echo 'bananas'
...
> [email protected] postinstall /Users/cdieringer/node/coinstac-ui/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~
> echo 'bananas'

bananas

> [email protected] postinstall /Users/cdieringer/node/coinstac-ui/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~/node_modules/~
> echo 'bananas'

bananas

clearly, my postinstall hook does echo 'bananas'

@kolodny
Copy link
Owner

kolodny commented May 4, 2016

I can't seem to replicate this, can you provide the instruction to make this happen. Here's what I'm trying now

$ mkdir tmp
$ npm init -y >/dev/null && npm i --save wavy && echo 'bananas' && npm i
$ find .
.
./node_modules
./node_modules/wavy
./node_modules/wavy/.npmignore
./node_modules/wavy/.travis.yml
./node_modules/wavy/package.json
./node_modules/wavy/postinstall.js
./node_modules/wavy/README.md
./node_modules/~
./package.json
$

@cdaringe
Copy link
Author

cdaringe commented May 4, 2016

np.

here: https://github.com/cdaringe/wavy-test

clone it. npm install twice. im on npm 2.15 FTR

@kolodny
Copy link
Owner

kolodny commented May 12, 2016

I see, I'm not sure how to go about fixing that. Any ideas?

@cdaringe
Copy link
Author

maybe remove and re-add the link on every postinstall? or, point the link to the dir it resides on pre-install, then on post install move it's target back up a dir?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants