Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unqoute url #7

Merged
merged 3 commits into from
Dec 19, 2024
Merged

fix: unqoute url #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7834521
fix: unqoute url
muse-sisay Dec 19, 2024
f469763
fix: fix url
muse-sisay Dec 19, 2024
efe8286
fix: use Konstruct username
muse-sisay Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/mirror-charts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ jobs:
mirror-charts:
uses: ./.github/workflows/tpl-mirror-charts.yaml
with:
registry-destination: "https://charts.konstruct.io/"
registry-destination: "https://charts.konstruct.io"
secrets: inherit
11 changes: 5 additions & 6 deletions .github/workflows/tpl-mirror-charts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,8 @@ jobs:

- name: "Validate Helm credentials"
run: |
export HURL_REGISTRY_DESTINATION="${{ inputs.registry-destination }}"
hurl --test <<EOF
POST "${{ inputs.registry-destination }}"/api/charts
POST ${{ inputs.registry-destination }}/api/charts
[BasicAuth]
{{HELM_REPO_USERNAME}}: {{HELM_REPO_PASSWORD}}

Expand All @@ -53,8 +52,8 @@ jobs:
jsonpath "$.error" == "EOF"
EOF
env:
HURL_HELM_REPO_USERNAME: "${{ secrets.TEST_CHARTMUSEUM_USER }}"
HURL_HELM_REPO_PASSWORD: "${{ secrets.TEST_CHARTMUSEUM_PASSWORD }}"
HURL_HELM_REPO_USERNAME: "${{ secrets.KONSTRUCT_CHARTMUSEUM_USER }}"
HURL_HELM_REPO_PASSWORD: "${{ secrets.KONSTRUCT_CHARTMUSEUM_PASSWORD }}"

- name: "Upload Helm charts to a different museum"
if: github.ref == 'refs/heads/main'
Expand All @@ -66,5 +65,5 @@ jobs:
helm-push "${tgz}" "${{ inputs.registry-destination }}" --force
done
env:
HELM_REPO_USERNAME: "${{ secrets.TEST_CHARTMUSEUM_USER }}"
HELM_REPO_PASSWORD: "${{ secrets.TEST_CHARTMUSEUM_PASSWORD }}"
HURL_HELM_REPO_USERNAME: "${{ secrets.KONSTRUCT_CHARTMUSEUM_USER }}"
HURL_HELM_REPO_PASSWORD: "${{ secrets.KONSTRUCT_CHARTMUSEUM_PASSWORD }}"
Loading