Several adjustments needed #277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ContentItemCreateModel - AssetWithRenditionsReference Allow settable Id (for unittests): - ElementMetadataBase Return null for content not found instead of an exception: - ActionInvoker - ManagementHttpClient Allow injection of HttpClient - ManagementClient - HttpClient
|
hello and thank you for the PR, apologies for a rather late reply. since this seems to be a recurring request, I'll make this a priority and review the proposed changes. will let you know with any updates, thanks for your patience! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow extension of models (remove sealed):
Allow settable Id (for unittests):
Return null for content not found instead of an exception:
Allow injection of HttpClient
Motivation
Fixes #270
And several changes that allow us to extend the models used, and to not throw Exceptions on items not found (but rather return null instead). This is a breaking change ofcourse, but having to catch Exceptions to check if something exists is very cumbersome.
Checklist
How to test
If manual testing is required, what are the steps?