Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't listen to beforeunload events unconditionally #203

Open
bjuppa opened this issue Nov 28, 2023 · 0 comments
Open

Don't listen to beforeunload events unconditionally #203

bjuppa opened this issue Nov 28, 2023 · 0 comments

Comments

@bjuppa
Copy link
Member

bjuppa commented Nov 28, 2023

This line is always adding a a listener for the beforeunload event, which is not recommended:

kontour/resources/js/confirm-leave-page.js

Line 29 in 0cea1b6

window.addEventListener("beforeunload", function(event) {

See
https://developer.chrome.com/articles/page-lifecycle-api/#the-beforeunload-event
and investigate solutions where we move the adding and removal of the event listener into the dirty-setting event handlers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bjuppa