Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Condition chaining not working for java.referenced conditions #718

Open
1 task done
jmle opened this issue Nov 11, 2024 · 1 comment
Open
1 task done

[BUG] Condition chaining not working for java.referenced conditions #718

jmle opened this issue Nov 11, 2024 · 1 comment
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Milestone

Comments

@jmle
Copy link
Contributor

jmle commented Nov 11, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

0.5.3

Priority

Critical

Current Behavior

A condition like the following:

  when:
    or:
    - java.referenced:
        pattern: org.springframework.stereotype.Controller
        location: ANNOTATION
      as: class
      ignore: true
    - java.referenced:
        pattern: '* javax.xml.transform.Source'
        location: METHOD
      from: class

doesn't work because the chaining does not seem to work.

Expected Behavior

Said condition should work. We should at least be sending the class file to the chain, and further filtering in the next condition, but that doesn't seem to be the case.

How Reproducible

Always (Default)

Steps To Reproduce

  1. Run the above rule against the following project:

web-applications.zip

  1. One and only one issue should appear.

Environment

Anything else?

No response

@jmle jmle added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 11, 2024
@jmle jmle added this to Planning Nov 11, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Nov 11, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Nov 11, 2024
@jmle jmle moved this from 🆕 New to 🏗 In progress in Planning Nov 12, 2024
@jmle jmle self-assigned this Nov 12, 2024
jmle added a commit that referenced this issue Nov 18, 2024
See #718

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
@jmle jmle moved this from 🏗 In progress to ✅ Done in Planning Nov 18, 2024
jmle added a commit to jmle/analyzer-lsp that referenced this issue Nov 19, 2024
jmle added a commit to jmle/analyzer-lsp that referenced this issue Nov 19, 2024
jmle added a commit to jmle/analyzer-lsp that referenced this issue Nov 19, 2024
@jmle jmle added this to the v0.6.0 milestone Nov 19, 2024
jmle added a commit that referenced this issue Nov 20, 2024
See #718

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Status: ✅ Done
Development

No branches or pull requests

1 participant