Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Explicit target for "discovery" not found in the values returned by "--list-targets" flag #177

Closed
1 task done
kthatipally opened this issue Mar 14, 2024 · 2 comments · Fixed by #205
Closed
1 task done
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/high triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@kthatipally
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

v0.3.0

Priority

Undefined (Default)

Current Behavior

Hi Team,

I am looking to run just "discovery" on the inputs. However, when I check the available targets using the --list-targets option, I don't find the explicit target "discovery," despite it being valid and typically running by default for all targets.
The below are the targets that I see:

image

Expected Behavior

Returning "discovery" as a valid target in the list of targets will enable to execute just the "discovery" analysis on the input application.

How Reproducible

Always (Default)

Steps To Reproduce

Run the below: .\kantra-latest.exe analyze --list-targets
"discovery" is not listed

Environment

- OS: windows, linux

Anything else?

No response

@kthatipally kthatipally added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 14, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Mar 14, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Mar 14, 2024
@kthatipally
Copy link
Contributor Author

kthatipally commented Mar 21, 2024

Additional Analysis:
The --list-targets flag appears to create a new container and walk through all the folders in the rulesets to extract the values of the labels for targets ( values for the key under labels - konveyor.io/target)
In the case of "discovery" and "technology-usage", since there isn't a specific target value assigned, it doesn't show up in the list.

I tested without specifying the --target flag, and it seems to execute on all targets.
However, when explicitly specifying target=discovery (or any string), it functions as expected. This behavior is likely due to the label-selector including the target, so if --target flag is included, it runs all rules under the konveyor.io/include: always label (discovery and technology-usage)

defaultLabels := []string{"discovery"}

Works in the below cases:
./kantra.exe analyze --input testingsample --output report --target discovery --overwrite (This is working because of a bug: #176 )
./kantra.exe analyze --input testingsample --output report --label-selector discovery --overwrite

@pranavgaikwad pranavgaikwad moved this from 🆕 New to 📋 Backlog in Planning Mar 29, 2024
@pranavgaikwad pranavgaikwad added this to the v0.4.0 milestone Mar 29, 2024
@pranavgaikwad pranavgaikwad added priority/high triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Mar 29, 2024
@konveyor-ci-bot konveyor-ci-bot bot removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Mar 29, 2024
@pranavgaikwad pranavgaikwad self-assigned this Mar 29, 2024
@pranavgaikwad pranavgaikwad moved this from 📋 Backlog to 🏗 In progress in Planning Apr 23, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Planning Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/high triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants