Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Kantra won't recognize sources/targets exclusive to --rules folder #395

Open
1 task done
jmle opened this issue Nov 27, 2024 · 3 comments
Open
1 task done
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@jmle
Copy link
Contributor

jmle commented Nov 27, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

6.0.0.Alpha

Priority

Critical

Current Behavior

When specifying additional rules with --rules, if the contained rules have new sources/targets, they are not recognized by kantra when doing the analysis, and therefore rules are not triggered.

Expected Behavior

Kantra should recognize those sources and targets to be able to run the rules, otherwise they can't be used.

How Reproducible

Always (Default)

Steps To Reproduce

No response

Environment

Any

Anything else?

No response

@jmle jmle added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Nov 27, 2024
@jmle jmle added this to Planning Nov 27, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Nov 27, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label Nov 27, 2024
@dymurray
Copy link
Contributor

dymurray commented Dec 2, 2024

As a temporary workaround, instead of using --target you can also do --label-selector=konveyor.io/target=foo to get the desired result until this is fixed.

@shawn-hurley
Copy link
Contributor

What do we do today in the non-containerless world? I thought we decided that label selectors are not ever selectively applied and that it was on the user to add the correct labels if they were doing this. The only other option, is to have some sub-system add the always included label for these rules, and that might be possible in the rule parser, but wanted to know what we have today, because I think I could make an argument that this working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Status: 🆕 New
Development

No branches or pull requests

4 participants