Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-implement the approve plugin from prow #66

Open
djzager opened this issue Feb 8, 2024 · 3 comments
Open

Re-implement the approve plugin from prow #66

djzager opened this issue Feb 8, 2024 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@djzager
Copy link
Member

djzager commented Feb 8, 2024

From https://prow.k8s.io/plugins

Description

The approve plugin implements a pull request approval process that manages the 'approved' label and an approval notification comment. Approval is achieved when the set of users that have approved the PR is capable of approving every file changed by the PR. A user is able to approve a file if their username or an alias they belong to is listed in the 'approvers' section of an OWNERS file in the directory of the file or higher in the directory tree.

Per-repo configuration may be used to require that PRs link to an associated issue before approval is granted. It may also be used to specify that the PR authors implicitly approve their own PRs.
For more information see here.

Events handled
[GenericCommentEvent (any event for user text), pull_request, pull_request_review]

Source -- https://github.com/kubernetes/test-infra/tree/master/prow/plugins/approve

@djzager djzager added this to Planning Feb 8, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Feb 8, 2024
@djzager
Copy link
Member Author

djzager commented Feb 8, 2024

/kind feature
/triage accepted
/priority backlog

2 similar comments
@djzager
Copy link
Member Author

djzager commented Feb 8, 2024

/kind feature
/triage accepted
/priority backlog

@djzager
Copy link
Member Author

djzager commented Feb 8, 2024

/kind feature
/triage accepted
/priority backlog

@konveyor-ci-bot konveyor-ci-bot bot added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Feb 8, 2024
@djzager djzager moved this from 🆕 New to 📋 Backlog in Planning Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant