changes to test case

konveyor · Dec 20, 2024 · 454a667 · 454a667
1 parent c59b03d
commit 454a667
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 44 deletions.
diff --git a/cypress/e2e/tests/migration/applicationinventory/analysis/source_analysis.test.ts b/cypress/e2e/tests/migration/applicationinventory/analysis/source_analysis.test.ts
@@ -368,49 +368,38 @@ describe(["@tier1"], "Source Analysis", () => {
 
     // Automates customer bug MTA-2973
     it("Source analysis on tackle app public with custom rule", function () {
-        const applicationList = [
-            new Analysis(
-                getRandomApplicationData("tackle-public-customRule", {
-                    sourceData: this.appData["tackle-testapp-public"],
-                }),
-                getRandomAnalysisData(this.analysisData["tackle-testapp-public-customRule"])
-            ),
-        ];
-
-        // Analysis application with maven credential
-        cy.wait(2 * SEC);
+        const { appData, analysisData } = this;
+        const applicationData = getRandomApplicationData("tackle-public-customRule", {
+            sourceData: appData["tackle-testapp-public"],
+        });
+
+        const analysisDataCustomRule = analysisData["tackle-testapp-public-customRule"];
+
+        for (let i = 0; i < 2; i++) {
+            applicationsList.push(
+                new Analysis(applicationData, getRandomAnalysisData(analysisDataCustomRule))
+            );
+        }
+
+        // Analyze an application
+        const analyzeApplication = (application, credentials) => {
+            application.create();
+            if (credentials) application.manageCredentials(null, credentials.name);
+            application.analyze();
+            application.verifyAnalysisStatus("Completed");
+            application.validateIssues(analysisDataCustomRule.issues);
+            analysisDataCustomRule.issues.forEach((issue) => {
+                application.validateAffected(issue);
+            });
+        };
+
+        // Analyze application with Maven credentials
         Application.open();
-        applicationList[0].create();
-        applicationList[0].manageCredentials(null, maven_credential.name);
-        applicationsList.push(applicationList[0]);
-        cy.wait(5 * SEC);
-        applicationList[0].analyze();
-        applicationList[0].verifyAnalysisStatus("Completed");
-        applicationList[0].validateIssues(
-            this.analysisData["tackle-testapp-public-customRule"]["issues"]
-        );
-        this.analysisData["tackle-testapp-public-customRule"]["issues"].forEach(
-            (currentIssue: AppIssue) => {
-                applicationList[0].validateAffected(currentIssue);
-            }
-        );
+        analyzeApplication(applicationsList[0], maven_credential);
 
-        // Analysis application without maven credential
-        cy.wait(2 * SEC);
+        // Analyze application without Maven credentials
         Application.open();
-        applicationList[1].create();
-        applicationsList.push(applicationList[0]);
-        cy.wait(5 * SEC);
-        applicationList[1].analyze();
-        applicationList[1].verifyAnalysisStatus("Completed");
-        applicationList[1].validateIssues(
-            this.analysisData["tackle-testapp-public-customRule"]["issues"]
-        );
-        this.analysisData["tackle-testapp-public-customRule"]["issues"].forEach(
-            (currentIssue: AppIssue) => {
-                applicationList[1].validateAffected(currentIssue);
-            }
-        );
+        analyzeApplication(applicationsList[1], null);
     });
 
     it("Bug MTA-3701: Source analysis on tackle app with hash in Password", function () {

diff --git a/cypress/fixtures/analysis.json b/cypress/fixtures/analysis.json
@@ -1321,8 +1321,8 @@
             {
                 "name": "Hardcoded IP Address",
                 "category": "mandatory",
-                "source": "None",
-                "targets": ["cloud-readiness", "discovery"],
+                "sources": ["None"],
+                "targets": ["cloud-readiness"],
                 "effort": 1,
                 "totalEffort": 1,
                 "incidents": 1,
@@ -1334,8 +1334,8 @@
             {
                 "name": "Legacy configuration with io.konveyor.demo.config.ApplicationConfiguration",
                 "category": "mandatory",
-                "sources": ["java", "java-ee"],
-                "targets": ["cloud-readiness"],
+                "sources": ["traditional-corporate-framework"],
+                "targets": ["cloud-corporate-framework"],
                 "effort": 1,
                 "totalEffort": 1,
                 "incidents": 1,