Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 ensure converted directory is created. #59

Merged
merged 1 commit into from
Nov 3, 2023
Merged

🐛 ensure converted directory is created. #59

merged 1 commit into from
Nov 3, 2023

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Nov 3, 2023

Not sure what changed in the shim (or rulesets) but using :latest, the output directory is only created when rules are converted. Better practice to not rely on the shim creating it.

Fixes:

errors:
    - severity: Error
      description: 'open /addon/rules/converted: no such file or directory'
    - severity: Error
      description: 'Pod failed: Error'

@jortel jortel merged commit 711b0f4 into konveyor:main Nov 3, 2023
This was referenced Nov 22, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavgaikwad pranavgaikwad pranavgaikwad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jortel @pranavgaikwad