Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application create/update don't update associations consistently. #727

Closed
jortel opened this issue Jul 16, 2024 · 1 comment · Fixed by #733
Closed

Application create/update don't update associations consistently. #727

jortel opened this issue Jul 16, 2024 · 1 comment · Fixed by #733
Assignees
@mansam
Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. tech-debt This will not be worked on
Milestone
v0.6.0

Comments

@jortel
Copy link
Contributor

jortel commented Jul 16, 2024

Application create/update don't update associations consistently.
They both should omit(clause.Associations)
and replace them.

Likely some other resources need to be scrubbed as well.
@jortel jortel added the tech-debt This will not be worked on label Jul 16, 2024
@jortel jortel added this to the v0.6.0 milestone Jul 16, 2024
@jortel jortel added this to Planning Jul 16, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Jul 16, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jul 16, 2024
@mansam mansam mentioned this issue Jul 18, 2024
Merged
@mansam mansam self-assigned this Jul 18, 2024
@mansam mansam closed this as completed in 65d0910 Jul 26, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Planning Jul 26, 2024
dymurray pushed a commit that referenced this issue Oct 11, 2024
@mansam @dymurray
🌱 Omit associations during Create operations (#733)
8f03da2 
When inserting a new record, GORM will also attempt to insert records
into tables refered to by many-to-many relationships on the inserted
record. This commit attempts to ensure that associations are omitted
when inserting records, and then the associations are added to the join
tables separately.

Also fixes some spots where the Transaction handler was in the wrong
spot in the chain or missing entirely.

Fixes #727

---------

Signed-off-by: Sam Lucidi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mansam mansam

Labels
needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. tech-debt This will not be worked on
Projects
Planning
Status: ✅ Done
Milestone
v0.6.0
Development

Successfully merging a pull request may close this issue.

🌱 Omit associations during Create operations mansam/tackle2-hub
2 participants
@mansam @jortel