Skip to content

Commit

Permalink
🐛 Fix alignment on actions screen (#1605)
Browse files Browse the repository at this point in the history
- Address issues with css alignment on assessment actions page

Before: 
<img width="1430" alt="Screenshot 2023-12-11 at 10 47 34 AM"
src="https://github.com/konveyor/tackle2-ui/assets/11218376/6ecc7666-138a-4dde-b6fb-296da49d341e">

After: 
<img width="1436" alt="Screenshot 2023-12-11 at 10 49 42 AM"
src="https://github.com/konveyor/tackle2-ui/assets/11218376/266f1b39-d8bc-47e6-8474-88c8b14e267c">

Signed-off-by: ibolton336 <[email protected]>
  • Loading branch information
ibolton336 authored Dec 11, 2023
1 parent 1f99dd0 commit 21b7afd
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,7 @@
background-color: var(--pf-v5-global--warning-color--100) !important ;
margin-right: 10px;
}

.actions-col {
vertical-align: middle !important;
}
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ const DynamicAssessmentActionsRow: FunctionComponent<

return (
<>
<Td>
<Td className="actions-col">
<div>
{isReadonly ? null : !isDeleting && !isFetching && !isMutating ? (
<Button
Expand Down Expand Up @@ -253,7 +253,7 @@ const DynamicAssessmentActionsRow: FunctionComponent<
</div>
</Td>
{assessment ? (
<Td isActionCell>
<Td isActionCell className="actions-col">
<Button
type="button"
variant="plain"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
.actions-row {
min-height: 5vh;
}
.actions-col {
vertical-align: middle !important;
}
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import "./questionnaires-table.css";
import React, { useState } from "react";
import { Table, Tbody, Td, Th, Thead, Tr } from "@patternfly/react-table";

Expand Down Expand Up @@ -98,7 +99,7 @@ const QuestionnairesTable: React.FC<QuestionnairesTableProps> = ({
);

return (
<Tr key={questionnaire.name}>
<Tr key={questionnaire.name} className="actions-row">
<TableRowContentWithControls
{...tableControls}
item={questionnaire}
Expand All @@ -107,6 +108,7 @@ const QuestionnairesTable: React.FC<QuestionnairesTableProps> = ({
<Td
width={20}
{...getTdProps({ columnKey: "questionnaires" })}
className="actions-col"
>
{questionnaire.name}
</Td>
Expand Down

0 comments on commit 21b7afd

Please sign in to comment.