🐛 Address style issues on assessment summary / questionnaire view (#1706

) Resolves https://issues.redhat.com/browse/MTA-1880 - Adds spacing for vertical tabs to align with question table - Adds spacing for expanded section to meet PF standards as outlined in above issue comments from UXD - Adds Explanation term for explanation previously not labeled. <img width="1638" alt="Screenshot 2024-02-27 at 2 48 46 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/a5d915d9-7977-48cd-ac4c-5c3ca1cdc909"> --------- Signed-off-by: Ian Bolton <[email protected]> Co-authored-by: Scott Dickerson <[email protected]>
konveyor · Feb 28, 2024 · 5a30824 · 5a30824
1 parent 6040a5d
commit 5a30824
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 17 deletions.
diff --git a/client/public/locales/en/translation.json b/client/public/locales/en/translation.json
@@ -323,6 +323,7 @@
     "email": "Email",
     "error": "Error",
     "errorReport": "Error report",
+    "explanation": "Explanation",
     "exclude": "Exclude",
     "exportToIssue": "Export to Issue Manager",
     "facts": "Facts",

diff --git a/client/src/app/components/questionnaire-summary/questionnaire-summary.tsx b/client/src/app/components/questionnaire-summary/questionnaire-summary.tsx
@@ -166,6 +166,7 @@ const QuestionnaireSummary: React.FC<QuestionnaireSummaryProps> = ({
                 isVertical
                 aria-label="Tabs for summaryData sections"
                 role="region"
+                className="tabs-vertical-container__tabs"
               >
                 {[
                   <Tab

diff --git a/client/src/app/components/questions-table/questions-table.tsx b/client/src/app/components/questions-table/questions-table.tsx
@@ -178,11 +178,14 @@ const QuestionsTable: React.FC<{
                       className={spacing.pyLg}
                     >
                       <ExpandableRowContent>
-                        {question.explanation}
-                        <AnswerTable
-                          hideAnswerKey={hideAnswerKey}
-                          answers={question.answers}
-                        />
+                        <div className={spacing.mlMd}>
+                          <strong>{t("terms.explanation")}: &nbsp;</strong>
+                          <span>{question.explanation}</span>
+                          <AnswerTable
+                            hideAnswerKey={hideAnswerKey}
+                            answers={question.answers}
+                          />
+                        </div>
                       </ExpandableRowContent>
                     </Td>
                   </Tr>

diff --git a/client/src/app/pages/assessment-management/questionnaire/questionnaire-page.css b/client/src/app/pages/assessment-management/questionnaire/questionnaire-page.css
@@ -1,5 +1,10 @@
 .tabs-vertical-container {
   display: flex;
+  margin-top: 1.5em;
+}
+
+.tabs-vertical-container__tabs {
+  margin-top: 1.5em;
 }
 
 .tabs-vertical-container .pf-v5-c-tabs {

diff --git a/client/src/app/pages/assessment/components/assessment-summary/assessment-summary-page.css b/client/src/app/pages/assessment/components/assessment-summary/assessment-summary-page.css
diff --git a/client/src/app/pages/assessment/components/assessment-summary/assessment-summary-page.tsx b/client/src/app/pages/assessment/components/assessment-summary/assessment-summary-page.tsx
@@ -1,6 +1,5 @@
 import React from "react";
 import { useParams } from "react-router-dom";
-import "./assessment-summary-page.css";
 import QuestionnaireSummary, {
   SummaryType,
 } from "@app/components/questionnaire-summary/questionnaire-summary";