From 192d3b866a7f8fcc3a9fe18ed65f28eb6862a18c Mon Sep 17 00:00:00 2001
From: Scott Dickerson <sdickers@redhat.com>
Date: Tue, 13 Aug 2024 15:37:26 -0400
Subject: [PATCH] :bug: Split the reports landscape unknown/unassessed chart
 (#2052)

Resolves: https://issues.redhat.com/browse/MTA-2678

On the reports page, split the combine Unknown / Unassessed landscape
chart into separate charts.

Unknown and unassessed are two different risk states.

Signed-off-by: Scott J Dickerson <sdickers@redhat.com>
---
 client/public/locales/en/translation.json     |  1 -
 .../application-landscape.tsx                 | 23 +++++++++++++++----
 2 files changed, 18 insertions(+), 6 deletions(-)

diff --git a/client/public/locales/en/translation.json b/client/public/locales/en/translation.json
index 51f852fea0..0ae1df7d83 100644
--- a/client/public/locales/en/translation.json
+++ b/client/public/locales/en/translation.json
@@ -485,7 +485,6 @@
     "ticket": "Ticket",
     "trivialButMigratable": "Trivial but migratable",
     "type": "Type",
-    "unassessedOrUnknown": "Unassessed or unknown",
     "unassessed": "Unassessed",
     "unassigned": "Not yet assigned",
     "unknown": "Unknown",
diff --git a/client/src/app/pages/reports/components/application-landscape/application-landscape.tsx b/client/src/app/pages/reports/components/application-landscape/application-landscape.tsx
index cdc88f04e7..ed63631a35 100644
--- a/client/src/app/pages/reports/components/application-landscape/application-landscape.tsx
+++ b/client/src/app/pages/reports/components/application-landscape/application-landscape.tsx
@@ -190,16 +190,29 @@ export const ApplicationLandscape: React.FC<IApplicationLandscapeProps> = ({
           <FlexItem>
             <Donut
               isAssessment={false}
-              id="landscape-donut-unassessed"
-              value={landscapeData.unassessed + landscapeData.unknown}
+              id="landscape-donut-unknown"
+              value={landscapeData.unknown}
               total={landscapeData.applicationsCount}
               color={RISK_LIST.unknown.hexColor}
               riskLabel={
-                <Link to={getRisksUrl(["unknown"])}>
-                  {`${t("terms.unassessed")}/${t("terms.unknown")}`}
+                <Link to={getRisksUrl(["unknown"])}>{t("terms.unknown")}</Link>
+              }
+              riskTitle={t("terms.unknown")}
+            />
+          </FlexItem>
+          <FlexItem>
+            <Donut
+              isAssessment={false}
+              id="landscape-donut-unassessed"
+              value={landscapeData.unassessed}
+              total={landscapeData.applicationsCount}
+              color={RISK_LIST.unassessed.hexColor}
+              riskLabel={
+                <Link to={getRisksUrl(["unassessed"])}>
+                  {t("terms.unassessed")}
                 </Link>
               }
-              riskTitle={t("terms.unassessedOrUnknown")}
+              riskTitle={t("terms.unassessed")}
             />
           </FlexItem>
         </Flex>