-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to individually view all files attached to a task on the Analysis details view #1929
Comments
This issue is currently awaiting triage. |
@dymurray, @JustinXHale, @rromannissen -- for your consideration |
Full page looks great. |
Related changes: 1. extend BreadCrumbPath component to support non-links 2. refactor CSS styles for SimpleDocumentViewer to support both modal and in-page mode 3. create new route for the analysis details page: /applications/:applicationId/analysis-details/:taskId Reference-Url: konveyor#1929 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
@sjd78 |
Related changes: 1. extend BreadCrumbPath component to support non-links 2. refactor CSS styles for SimpleDocumentViewer to support both modal and in-page mode 3. create new route for the analysis details page: /applications/:applicationId/analysis-details/:taskId Reference-Url: konveyor#1929 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Related changes: 1. extend BreadCrumbPath component to support non-links 2. refactor CSS styles for SimpleDocumentViewer to support both modal and in-page mode 3. create new route for the analysis details page: /applications/:applicationId/analysis-details/:taskId Part-of: #1929 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Main use case is providing a link to the application drawer. Part-of: #1929 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Extract existing components to files. No functional changes have been introduced. Part-of: #1929 Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Resolves: konveyor#1929 Functional changes: 1. document to be viewed is selected from the list (first action above the editor) or via URL 2. display language toggle based on languages supported by the document. For attachments the list consists of plain text and optionally a second language discovered based on file extension (YAML or JSON). 3. replace "merged" checkbox with an option in the select Related refactorings: 1. split getTaskById() query into specialized queries: a) getTaskById() returning Promise<Task> for working with the object b) getTaskByIdAndFormat() returning Promise<string> for displaying the task as a formatted text 2. configure AnalysisDetails component to respond to 2 routes: existing details route and newly added /applications/:applicationId/analysis-details/:taskId/attachments/:attachmentId Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Resolves: konveyor#1929 Functional changes: 1. document to be viewed is selected from the list (first action above the editor) or via URL 2. display language toggle based on languages supported by the document. For attachments the list consists of plain text and optionally a second language discovered based on file extension (YAML or JSON). 3. replace "merged" checkbox with an option in the select Related refactorings: 1. split getTaskById() query into specialized queries: a) getTaskById() returning Promise<Task> for working with the object b) getTaskByIdAndFormat() returning Promise<string> for displaying the task as a formatted text 2. configure AnalysisDetails component to respond to 2 routes: existing details route and newly added /applications/:applicationId/analysis-details/:taskId/attachments/:attachmentId Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Resolves: konveyor#1929 Functional changes: 1. document to be viewed is selected from the list (first action above the editor) or via URL 2. display language toggle based on languages supported by the document. For attachments the list consists of plain text and optionally a second language discovered based on file extension (YAML or JSON). 3. replace "merged" checkbox with an option in the select Related refactorings: 1. split getTaskById() query into specialized queries: a) getTaskById() returning Promise<Task> for working with the object b) getTaskByIdAndFormat() returning Promise<string> for displaying the task as a formatted text 2. configure AnalysisDetails component to respond to 2 routes: existing details route and newly added /applications/:applicationId/analysis-details/:taskId/attachments/:attachmentId Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Resolves: konveyor#1929 Functional changes: 1. document to be viewed is selected from the list (first action above the editor) or via URL 2. display language toggle based on languages supported by the document. For attachments the list consists of plain text and optionally a second language discovered based on file extension (YAML or JSON). 3. replace "merged" checkbox with an option in the select Related refactorings: 1. split getTaskById() query into specialized queries: a) getTaskById() returning Promise<Task> for working with the object b) getTaskByIdAndFormat() returning Promise<string> for displaying the task as a formatted text 2. configure AnalysisDetails component to respond to 2 routes: existing details route and newly added /applications/:applicationId/analysis-details/:taskId/attachments/:attachmentId Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Resolves: konveyor#1929 Functional changes: 1. document to be viewed is selected from the list (first action above the editor) or via URL 2. display language toggle based on languages supported by the document. For attachments the list consists of plain text and optionally a second language discovered based on file extension (YAML or JSON). 3. replace "merged" checkbox with an option in the select Related refactorings: 1. split getTaskById() query into specialized queries: a) getTaskById() returning Promise<Task> for working with the object b) getTaskByIdAndFormat() returning Promise<string> for displaying the task as a formatted text 2. configure AnalysisDetails component to respond to 2 routes: existing details route and newly added /applications/:applicationId/analysis-details/:taskId/attachments/:attachmentId 3. persist merge mode in the URL as search param "merged" Signed-off-by: Radoslaw Szwajkowski <[email protected]>
Summary
For an application, the activity of the current / most recently run analysis task:
The enhancement will make a few changes:
Enhancements reference:
Requirements
Viewing each file individually
Existing functionality to keep:
Allow viewing all of the task's attached files by adding a select box to the top of the viewer. The select box should:
Additional functionality:
View moved to a full page
The current view opens in a modal window. In order to have more screen space to view the logs and provide selection of attached files, move the view from the modal to a full page.
/applications/123/task-view/456
)Some potential examples of the bread crumbs (including some potential future uses):
Screen shots and mockups
Current State
Open the view from the kebab menu:
Open the view from the application details drawer report tab:
View an analysis details (task activity log):
Future State Mockups
Attached file list box and on page view:
Attached file list box opened to select a different file to view:
Viewing an attached file:
The text was updated successfully, but these errors were encountered: