Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 ci-repo: concurrency limits, codecov upload #2056

Merged
merged 1 commit into from
Aug 22, 2024
Merged

🌱 ci-repo: concurrency limits, codecov upload #2056

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/ci-repo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ on:

workflow_call:

concurrency:
group: ci-repo-${{ github.event_name }}-${{ github.ref }}
cancel-in-progress: true

jobs:
unit-test-lookup-image:
runs-on: ubuntu-latest
Expand Down Expand Up @@ -61,14 +65,14 @@ jobs:
run: npm run test -- --coverage --watchAll=false

- name: Upload to codecov (client)
if: ${{ github.event.pull_request }}
# if: ${{ github.event.pull_request }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our PR branches are mostly short-lived - I'm not sure if this is the main reason of codecov being out of synch (as of this PR its 200+ commits). Let's see it in action.

uses: codecov/codecov-action@v4
with:
flags: client
directory: ./client/coverage

- name: Upload to codecov (server)
if: ${{ github.event.pull_request }}
# if: ${{ github.event.pull_request }}
uses: codecov/codecov-action@v4
with:
flags: server
Expand Down
Loading