Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support relocated artifacts #30

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Support relocated artifacts #30

merged 2 commits into from
Oct 22, 2024

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi mentioned this pull request Oct 22, 2024
Closed
@gastaldi
Copy link
Contributor Author

/cc @aalmiray

@aalmiray
Copy link
Contributor

aalmiray commented Oct 22, 2024 •
edited
Loading

According to the guide the relocation block should contain only the elements that were changed, which could be groupId, artifactId, and/or version.

This PR treats groupId as required. Instead, it should check if any of groupId, artifactId, version are defined.

aalmiray
aalmiray requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@aalmiray aalmiray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the required check for groupId.

@gastaldi gastaldi requested a review from aalmiray October 22, 2024 14:08
@gastaldi gastaldi force-pushed the relocation branch 2 times, most recently from f1580d4 to 7210f6f Compare October 22, 2024 14:23
@aalmiray aalmiray added the enhancement New feature or request label Oct 22, 2024
@aalmiray aalmiray merged commit 15009ec into kordamp:master Oct 22, 2024
1 check passed
@aalmiray
Copy link
Contributor

Thanks 😄

@gastaldi gastaldi deleted the relocation branch October 22, 2024 16:06
@aalmiray
Copy link
Contributor

Manually verified changes with a local build and latest JReleaser updates.
Posting a release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalmiray aalmiray aalmiray approved these changes

Assignees

@gastaldi gastaldi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gastaldi @aalmiray