Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's make commented exceptions introduced in #378 working (WIP) #381

Open
cramoisi opened this issue Sep 17, 2020 · 4 comments
Open

Let's make commented exceptions introduced in #378 working (WIP) #381

cramoisi opened this issue Sep 17, 2020 · 4 comments

Comments

@cramoisi
Copy link
Contributor

cramoisi commented Sep 17, 2020

Ok, work in progress as it's soooo boring to do :)

Commented exceptions can be replaced by these sets of rules. if a commented exception is not present in a provided set of rules, it's because the word won't be cut so there is no use for it as a pattern. Several reason to this, the main one is the left and right minhyphen values. Other reason is there is no rule applied to the word 😅. (As changing the left/right hyphmin require to add a lot of rules in the pattern file for it to continue to work properly , we can assume it will never happen by accident ?)

Esperanto

<pattern>uzul­6in­6ter­6fa­6co</pattern>

Irish

<pattern>bhracht6aí</pattern>
<pattern>mbracht6aí</pattern>
<pattern>cheil6tí</pattern>
<pattern>chreat6aí</pattern>
<pattern>gcreat6aí</pattern>
<pattern>dhoir6teá</pattern>
<pattern>dhoir6tear</pattern>
<pattern>doir6tear</pattern>
<pattern>ndoir6teá</pattern>
<pattern>ndoir6tear</pattern>
<pattern>bhfuad6ar</pattern>
<pattern>bhfua6far</pattern>
<pattern>fhua6far</pattern>
<pattern>fua6far</pattern>
<pattern>gheal6taí</pattern>
<pattern>ngeal6taí</pattern>
<pattern>ghort6aí</pattern>
<pattern>ngort6aí</pattern>
<pattern>meat6aí</pattern>
<pattern>mheat6aí</pattern>
<pattern>réalt6aí</pattern>
<pattern>rí6fear</pattern>
<pattern>sá6dar</pattern>
<pattern>shá6dar</pattern>
<pattern>sá6imis</pattern>
<pattern>shá6imis</pattern>
<pattern>sá6faí</pattern>
<pattern>shá6faí</pattern>
<pattern>speal6ta</pattern>
@cramoisi
Copy link
Contributor Author

Norwegian

line 27572 need a correction as there is a closing remaining closing comment on it.

<pattern>po8li8sen</pattern>
<pattern>Hel8m8ut</pattern>
<pattern>Ni8el8sen</pattern>
<pattern>Ni8el8sens</pattern>
<pattern>Stei8n8ar</pattern>
<pattern>Stei8n8ars</pattern>
<pattern>Stend8hal</pattern>
<pattern>Stend8hals</pattern>
<pattern>av8i8ser</pattern>
<pattern>bet8re</pattern>
<pattern>bor8t8re</pattern>
<pattern>che8ese</pattern>
<pattern>no8ens</pattern>
<pattern>po8lis</pattern>
<pattern>sple8en</pattern>
<pattern>tres8kje</pattern>
<pattern>vel8an</pattern>
<pattern>vel8et</pattern>

@cramoisi
Copy link
Contributor Author

cramoisi commented Sep 17, 2020

Slovak

the commented exception can be remove : the word will never be cut with left/right hyphmin 2, 3

(done for today)

@poire-z
Copy link
Contributor

poire-z commented Sep 18, 2020

You want to do a PR?
Or do you want me to quickly do one with these before bumping what we merged yesterday?

@cramoisi
Copy link
Contributor Author

I will do a PR when I'm finished. There is no rush ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants