CSS: switch cr-hint from enum to bitmap #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just moved some stuff from .h to .cpp as it's only used there.
Frenzie
approved these changes
Jul 19, 2020
crengine/src/lvtextfm.cpp
Outdated
| // we have non-space-only text in the paragraph - standalone images | ||
| // possibly separated by spaces don't need to be reduced in size. | ||
| m_allow_strut_confinning = false; | ||
| bool has_non_space = false; // If we have non-empty text, we can do strut confinning |
crengine/src/lvtextfm.cpp
Outdated
| // possibly separated by spaces don't need to be reduced in size. | ||
| // And only when we actually have a strut set (list item markers | ||
| // with "list-style-position: outside" don't have any set). | ||
| m_allow_strut_confinning = has_non_space && m_pbuffer->strut_height > 0; |
There was a problem hiding this comment.
Ah, purposeful typo because the rest of the code is already typod? :-)
There was a problem hiding this comment.
Yeah... and I remember at the time I googled it to see how it's written, with one n or two.
But now, some months later, the Google results are different ! :)
List item markers with "list-style-position: outside" don't have any strut set: the arithmetic with a strut height of 0 could cause clipping issues with in-page footnotes.
This allows setting multiple hints on a same node (i.e. "-cr-hint: footnote-inpage strut-confined").
This was referenced Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Upstream) lvstsheet: avoid compilation warningsFix some issue affecting upstream only, See #339 (comment)
Strut confinning: don't when there is no strutFix list item markers not showing in in-page footnotes (when
-cr-hint: footnote-inpage strut-confined, allowed with next commit).CSS: switch cr-hint from enum to bitmapAllows specifying multiple hints on a same node. Might help with #355 if we allow glyph overflows by default, and want to get previous behaviour by specifying it via
-cr-hint:(on all elements, on only some like tables).This change is