Consecutive initial marks/dashes spacing tweak + some sync with Upstream #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't trigger it on KOReader. Quick fix (should probably be ensured earlier) picked just to not diverge.
Used with text files when detecting encoding.
|
Whee, that means we'll be able to get rid of that stupid font sizes array in cre.cpp \o/. |
Frenzie
reviewed
Mar 21, 2021
| @@ -63,8 +63,8 @@ void MakeStats() | |||
| MakeStatsForFile( BASE_DIR "es2-utf8.txt", "utf8", "ee", 2, f, list ); | |||
| MakeStatsForFile( BASE_DIR "ee3-cp775.txt", "cp775", "ee", 1, f, list ); | |||
| MakeStatsForFile( BASE_DIR "es3-cp1257.txt", "cp1257", "ee", 2, f, list ); | |||
| MakeStatsForFile( BASE_DIR "gr1-cp1253.txt", "cp1253", "gr", 1, f, list ); | |||
| MakeStatsForFile( BASE_DIR "gr1-cp737.txt", "cp737", "gr", 1, f, list ); | |||
| MakeStatsForFile( BASE_DIR "gr1-cp1253.txt", "cp1253", "el", 1, f, list ); | |||
There was a problem hiding this comment.
Strange, didn't we discuss this on our end recently?
There was a problem hiding this comment.
Now that you mention it, that does vaguely ring a bell (perhaps not strictly in the same context, though)...
There was a problem hiding this comment.
Probably in some hyphenation topic, like #373 (comment).
Mostly large zip-files. Integer overflow fixed.
Upstream had been keeping both SetFallbackFontFace() and SetFallbackFontFaces(), and recently removed the former. We've been having only the plural, but kept the setting singular for compatibility. Make everything plural to keep in sync.
Previously, the default font size was limited to a (configurable) set of sizes. This adds an option to not enforce that, and use the requested font size as-is. (Set USE_LIMITED_FONT_SIZES_SET=0 for KOReader, as cre.cpp needs the correct headers.)
Extend 2504a40 to keep doing it when multiple such initial quotation marks/dashes separated by spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Upstream) Fix rescaled book cover on 4bpp screen
buggins/coolreader@43a4feb
(Upstream) Page splitting: fix possible infinite loop
buggins/coolreader@d698181
Can't trigger it on KOReader.
Quick fix (should probably be ensured earlier) picked just to not diverge.
(Upstream) Correct the language code for Greek
buggins/coolreader@f1d3096
Used with text files when detecting encoding.
(Upstream) Fix typo in LVDocView::propsApply()
buggins/coolreader@3845336
(Upstream) Large files support (engine part)
buggins/coolreader@29707a0
Mostly large zip-files. Integer overflow fixed.
(Upstream) Make crengine.font.fallback.faces plural
buggins/coolreader@e7c85ef
Upstream had been keeping both SetFallbackFontFace() and SetFallbackFontFaces(), and recently removed the former. We've been having only the plural, but kept the setting singular for compatibility.
Make everything plural to keep in sync.
(Upstream) Option to not limit font size to a set
buggins/coolreader@3a2bc01
Previously, the default font size was limited to a (configurable) set of sizes.
This adds an option to not enforce that, and use the requested font size as-is.
(Set USE_LIMITED_FONT_SIZES_SET=0 for KOReader, as cre.cpp needs the correct headers - and it feels awkward to pollute our base/Makefile with such a little -D.)
Text: dont adjust space after consecutive initial marks/dashes
See koreader/koreader#7366 (comment).
Extend 2504a40 to keep doing it when multiple such initial quotation marks/dashes separated by spaces.
This change is