lvfntman: fix LVFontGlobalGlyphCache::removeNoLock
#532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cache size was not updated when removing the last item. Potential impact: negligible, between 64 and 316 bytes on each book opening after the first one, resulting in a ~1% reduction in usable cache size after opening 17 books.
|
I remember you mentionned at #506 (comment):
I guess this PR is not that - but has that already comes in? |
poire-z
approved these changes
Oct 3, 2023
No, this is this patch. |
Frenzie
approved these changes
Oct 3, 2023
benoit-pierre
added a commit
to benoit-pierre/koreader-base
that referenced
this pull request
Oct 26, 2023
- koreader/crengine#527 - koreader/crengine#528 - koreader/crengine#530 - koreader/crengine#531 - koreader/crengine#532 - koreader/crengine#533 - koreader/crengine#534 - koreader/crengine#535 - koreader/crengine#536 - koreader/crengine#538 - koreader/crengine#539 - koreader/crengine#540 - koreader/crengine#541 - koreader/crengine#542 - koreader/crengine#544
Frenzie
pushed a commit
to koreader/koreader-base
that referenced
this pull request
Oct 30, 2023
- koreader/crengine#527 - koreader/crengine#528 - koreader/crengine#530 - koreader/crengine#531 - koreader/crengine#532 - koreader/crengine#533 - koreader/crengine#534 - koreader/crengine#535 - koreader/crengine#536 - koreader/crengine#538 - koreader/crengine#539 - koreader/crengine#540 - koreader/crengine#541 - koreader/crengine#542 - koreader/crengine#544
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache size was not updated when removing the last item.
Potential impact: negligible, between 64 and 316 bytes on each book opening after the first one, resulting in a ~1% reduction in usable cache size after opening 17 books.
This change is