Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #582

Closed
wants to merge 52 commits into from
Closed

Testing #582

wants to merge 52 commits into from

Commits on Jul 21, 2024

  1. lvptrvec: fix compiler warnings

    ```
    template-id not allowed for constructor/destructor in C++20
    ```
    benoit-pierre committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    a56f6c0 View commit details
    Browse the repository at this point in the history
  2. qimagescale: fix compiler warnings

    About (possibly) unused functions.
    benoit-pierre committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    c96a3f3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b446873 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    76e6e24 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c891656 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Configuration menu
    Copy the full SHA
    3913efd View commit details
    Browse the repository at this point in the history
  2. lvstsheet: fix parse_integer prototype and associated compiler warn…

    …ings
    
    The function actually parses an unsigned integer.
    benoit-pierre committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    405bb94 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7f5ae87 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b9f5d57 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d4f5a64 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    97b1ddd View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    01c9b19 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d2aeb52 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f8d7ed7 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    273050c View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b9a02df View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    3a2e6e7 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a35c257 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    a9d7528 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    30033b6 View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    6deea77 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    6b69446 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    e5ccfb4 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    682a79b View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    b313d56 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    aba10b1 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    e99d4ab View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    fa5fead View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    8d3e28b View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    8d3543a View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    45cecae View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    71715fa View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    b908a75 View commit details
    Browse the repository at this point in the history
  29. lvref: fix cppcheck warnings

    ```
    warning: Rethrowing current exception with 'throw;', it seems there is no current
    exception to rethrow. If there is no current exception this calls std::terminate().
    ```
    benoit-pierre committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    541eb11 View commit details
    Browse the repository at this point in the history
  30. lvref: fix cppcheck warning

    Comment out unused & problematic code:
    ```
    crengine/include/lvref.h:395:16: warning: Reference to temporary returned. [returnTempReference]
       return LVRef(NULL);
                   ^
    crengine/include/lvref.h:396:15: warning: Reference to temporary returned. [returnTempReference]
      return LVRef( new T( *_ptr ) );
    ```
    benoit-pierre committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    f74dab9 View commit details
    Browse the repository at this point in the history
  31. wordfmt: fix clang-tidy warning

    ```
    warning: Value stored to 'pDiag' is never read [clang-analyzer-deadcode.DeadStores]
    ```
    benoit-pierre committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    3fca07a View commit details
    Browse the repository at this point in the history
  32. lvarray: fix cppcheck warnings

    ```
    warning: Rethrowing current exception with 'throw;', it seems there is no current
    exception to rethrow. If there is no current exception this calls std::terminate().
    ```
    benoit-pierre committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    a67e93e View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. ci: improve linting

    - fix cppcheck & clang-tidy configurations to avoid parsing, processing,
      and/or spurious errors.
    - parallelize all checks to speed up linting (which is much slower now
      that cppcheck & clang-tidy can actually do their jobs).
    - always lint all files (we care about), instead of trying to determine
      what changed: even if a source file, say `crengine/src/lvtinydom.cpp`,
      was not changed in a PR, some change to included headers may break
      something that could be detected by one of the checks.
    - plus colors, groups and error annotations on Github Actions!
    benoit-pierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5161264 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0802454 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e5e9427 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    053460d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    83b8896 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    190aadc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    a769e5f View commit details
    Browse the repository at this point in the history
  8. ci: stop linting with nanosvg support enabled

    - cppcheck does not like it
    - it does not match our default configuration on koreader anyway
      (where we use lunasvg)
    benoit-pierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    9498f02 View commit details
    Browse the repository at this point in the history
  9. lvrefcache: tweak LVCacheMap implementation

    To make cppcheck happy.
    benoit-pierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    c93f7d0 View commit details
    Browse the repository at this point in the history
  10. textlang: get rid of LANG_STARTS_WITH(…) macro hack

    Simplify the code and make cppcheck happy.
    benoit-pierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f7df989 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    a8d7ee7 View commit details
    Browse the repository at this point in the history
  12. comment out / don't compile concurrency code

    - it's already stubbed anyway, stub it more!
    - I have seen at least one crash with the default stub (clang emulator)
    - cppcheck is not happy about it
    benoit-pierre committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e58bdd0 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Configuration menu
    Copy the full SHA
    37a2460 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0c8ab9d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f1061e8 View commit details
    Browse the repository at this point in the history