Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce HTTPS on koreader.rocks #7

Open
captn3m0 opened this issue Mar 26, 2019 · 3 comments
Open

Enforce HTTPS on koreader.rocks #7

captn3m0 opened this issue Mar 26, 2019 · 3 comments

Comments

@captn3m0
Copy link

The website currently works on HTTP by default. GitHub now supports SSL for custom domains, so while https://koreader.rocks works, it is not enforced.

It is just a flip away at https://github.com/koreader/koreader.github.io/settings

See https://help.github.com/en/articles/securing-your-github-pages-site-with-https#enforcing-https-for-your-github-pages-site for more details.

@Frenzie
Copy link
Member

Frenzie commented Mar 26, 2019

It is just a flip away at https://github.com/koreader/koreader.github.io/settings

That is not, in fact, the case. (Notice how it's Cloudflare.) Pinging @houqp to ask if he can update the config, because Google.

I'll just drop this here for good measure:
https://burningbird.net/google-power-give-exchange-security/
https://shelleystoybox.com/moving-https/

@captn3m0
Copy link
Author

captn3m0 commented Mar 26, 2019 via email

@Frenzie Frenzie removed the wontfix label Mar 26, 2019
@Frenzie
Copy link
Member

Frenzie commented Mar 26, 2019

That's more about, e.g., build.koreader.rocks and ota.koreader.rocks. I'll leave it to @houqp to decide whether a special exception makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants