-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce HTTPS on koreader.rocks #7
Comments
That is not, in fact, the case. (Notice how it's Cloudflare.) Pinging @houqp to ask if he can update the config, because Google. I'll just drop this here for good measure: |
I saw the CNAME file in the repo root and assumed it was served directly. Now that GitHub supports HTTPS natively, there should be no need to route it via CF.
|
That's more about, e.g., build.koreader.rocks and ota.koreader.rocks. I'll leave it to @houqp to decide whether a special exception makes sense. |
The website currently works on HTTP by default. GitHub now supports SSL for custom domains, so while https://koreader.rocks works, it is not enforced.
It is just a flip away at https://github.com/koreader/koreader.github.io/settings
See https://help.github.com/en/articles/securing-your-github-pages-site-with-https#enforcing-https-for-your-github-pages-site for more details.
The text was updated successfully, but these errors were encountered: