Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Kosli CLI diagnostics suggestions based on customer-support call #354

Open
2 tasks
JonJagger opened this issue Oct 11, 2024 · 1 comment
Open
2 tasks

Comments

@JonJagger
Copy link
Contributor

JonJagger commented Oct 11, 2024

Bug report from a customer this morning. They pasted in the GitHub action output, as follows:

flow 'pottspillsport-lambda-rs-bet-detail-producer' was updated
trail '4652946727ba47b45f99ef8d2055518a68fad924' was begun
artifact bet-detail-producer-v0.45.0.zip was attested with fingerprint: 62ede6da090...
Error: xml: encoding "ISO-8859-15" declared but Decoder.CharsetReader is nil
  • It would be very useful if the CLI printed its version number before each fatal error message.
    I could not reproduce this particular error in the latest CLI so I wanted to install the specific version they were using.

  • It would also have been very handy if the error message also told you the filename involved.
    In this case the customer was using a kosli attest junit command and was providing an --attachments flag
    specifying a junit xml file in a subdir. The --results-dir was defaulting to . and they were somehow under the impression
    that since they had specified --attachments then that somehow took precedence over the --results-dir (which would then be ignored). But there was another junit xml file in the . dir (which had encoding problems). If we'd printed the filename we would have saved half a day debugging, and the customer might well have been able to diagnose the problem themself.

@JonJagger JonJagger changed the title Print Kosl CLI version number before exiting with a fatal error Better Kosl CLI diagnostics based on customer-support call Oct 11, 2024
@JonJagger JonJagger changed the title Better Kosl CLI diagnostics based on customer-support call Better Kosli CLI diagnostics based on customer-support call Oct 11, 2024
@JonJagger JonJagger changed the title Better Kosli CLI diagnostics based on customer-support call Better Kosli CLI diagnostics suggestions based on customer-support call Oct 12, 2024
@JonJagger
Copy link
Contributor Author

JonJagger commented Oct 25, 2024

Today I hit this error while trying to move past a new snyk vulnerability in cyber-dojo's creator Pipeline (in Gitlab).
https://gitlab.com/cyber-dojo/creator/-/jobs/8185260142#L260

Error: Error response from daemon: client version 1.44 is too new. Maximum supported API version is 1.43

I again request that we consider the idea of CLI printing its identity (or something similar) before it prints, verbatim, any error messages it receives from external calls...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant