Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify AccessToken and RefreshToken #13

Open
sunsingerus opened this issue May 30, 2017 · 1 comment
Open

Unify AccessToken and RefreshToken #13

sunsingerus opened this issue May 30, 2017 · 1 comment

Comments

@sunsingerus
Copy link
Contributor

SUPPOSITION
App\Model\AccessToken and App\Model\RefreshToken are very much the same - the main difference is inside createToken()

PROPOSITION*
Let's extract common functionality into new App\Model\Token class and rework RefreshToken and AccessToken to be children of Token

PS. I can implement this
@sunsingerus
Copy link
Contributor Author

ok, let's return later to tokens, it is not first-priority issue at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sunsingerus