Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py assumes MSVC on Windows #28

Open
us88 opened this issue Jun 6, 2022 · 1 comment
Open

setup.py assumes MSVC on Windows #28

us88 opened this issue Jun 6, 2022 · 1 comment

Comments

@us88
Copy link

us88 commented Jun 6, 2022

We'd like to use MinGW on Windows to compile this library, though line 22 is appending "/O2" explicitly:

cargs = ('/O2' if iswindows else '-O3').split()

There should probably be something in place to detect if someone is using Microsoft's Compiler or Clang or GCC

@kovidgoyal
Copy link
Owner

You are welcome to send a patch for it, I never use non-native
compilers for platforms that have native compilers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants