Skip to content
This repository has been archived by the owner on Feb 9, 2022. It is now read-only.

Packages with environment markers are not parsed correctly #247

Open
caniko opened this issue Jul 6, 2021 · 1 comment
Open

Packages with environment markers are not parsed correctly #247

caniko opened this issue Jul 6, 2021 · 1 comment

Comments

@caniko
Copy link

caniko commented Jul 6, 2021

Describe the bug
The bpy package is configured with different versions depending on the current OS:

bpy = [
    {"version" = "^2.91a0", markers="sys_platform!='win32'"},
    {"version" = "^2.82.1", markers="sys_platform=='win32'"}
]

The plugin doesn't recognize the markers, and PyCharm, thereby, believes that I have the wrong version installed:
image

To Reproduce
Add a package to pyproject.toml with the same method as mentioned above PyCharm should react if your current version isn't the 1st one on the list.

Expected behavior
The plugin should iterate through the markers (there can be multiple per entry), and figure out the correct version before alarming the user of the improper version being installed.

Environments (please complete the following information):

  • IDE: PyCharm Community 2021.1
  • OS: Windows 10
  • Poetry Version 1.1.7
  • Plugin version 1.1.4
@caniko caniko changed the title OS dependent versions are not detected Packages with multi-marker versioning are not parsed correctly Jul 6, 2021
@caniko caniko changed the title Packages with multi-marker versioning are not parsed correctly Packages with environment markers are not parsed correctly Jul 6, 2021
@koxudaxi
Copy link
Owner

koxudaxi commented Aug 1, 2021

@caniko
Thank you for creating this issue.
I guess the plugin could not parse a in "^2.91a0"
I will fix it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants