Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to edit schema after graph is created #32

Open
joshcho opened this issue Nov 26, 2022 · 0 comments
Open

Unable to edit schema after graph is created #32

joshcho opened this issue Nov 26, 2022 · 0 comments

Comments

@joshcho
Copy link

joshcho commented Nov 26, 2022

This issue deals with

(setf (schema-class-locks schema) nil)
(setf (schema-lock schema) nil)
(cl-store:store (schema graph) schema-file)
(setf (schema-lock schema) schema-lock)
(setf (schema-class-locks schema) locks)
and

vivace-graph-v3/graph.lisp

Lines 130 to 133 in cf2caaf

(if (probe-file schema-file)
(setf (schema graph)
(cl-store:restore schema-file))
(init-schema graph))

I noticed that after making the graph, its schema is stored without any of its class locks or locks. Then when it's restored, the class locks nor locks return, resulting in (schema-class-locks (schema graph)) being nil. This prevents some functions that use instantiate-node-type, e.g. def-edge.

To recreate, make an empty graph, close it, open it again, just to notice schema-class-locks being nil. Then you can't def-edge.

Temporarily I have made a workaround to this issue in my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant