Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create TypeScript typings #36

Open
mstuart opened this issue Oct 2, 2020 · 13 comments
Open

Create TypeScript typings #36

mstuart opened this issue Oct 2, 2020 · 13 comments

Comments

@mstuart
Copy link
Contributor

mstuart commented Oct 2, 2020

This project isn't written in TypeScript, but many TypeScript users would like to use published typings. For this issue, create TypeScript typings that cover the exported functions, and contribute it back to DefinitelyTyped!

This issue is great for someone who wants to learn more about TypeScript!

@ba11b0y
Copy link

ba11b0y commented Oct 7, 2020

Taking this up! @mstuart

@mstuart
Copy link
Contributor Author

mstuart commented Oct 13, 2020

@invinciblycool Go for it! Happy hacking

@mstuart
Copy link
Contributor Author

mstuart commented Oct 21, 2020

Hi @invinciblycool, just wanted to follow up. Can you take this up? If not, wanted to leave it open for others to contribute before the end of the month. Thanks!

@ba11b0y
Copy link

ba11b0y commented Oct 21, 2020

Hey @mstuart, sorry for the delay.
Sending a PR soon!! 😄

@mstuart
Copy link
Contributor Author

mstuart commented Oct 21, 2020

np!!

@Salketer
Copy link

Salketer commented May 7, 2021

Hey @ba11b0y have you had time to finish up? Is there a spot where I eventually could take on the rest of the work if you are missing some parts?

@ba11b0y
Copy link

ba11b0y commented May 7, 2021 via email

@mstuart
Copy link
Contributor Author

mstuart commented Oct 4, 2021

Hi @Salketer, did you do any work on this? Let me know and I'll assign to you. Thanks!

@Salketer
Copy link

Salketer commented Oct 4, 2021

Hey there @mstuart nice to see you around. Unfortunately we didn't get the time to advance on this topic. We didn't implement this in our software yet so I can't really say I'm on it... I'm definitely interested in having this/work on it but priorities shifted a bit since last comment...

I'll let you know when we start working on it, but feel free to ping me if there's interest!

@mstuart
Copy link
Contributor Author

mstuart commented Oct 4, 2021

Definitely still interested in someone picking this up. If you're able to later, let me know!

@ispedals
Copy link

I would like to work on this. I am basing the work off the pull request for zalgo-promise (DefinitelyTyped/DefinitelyTyped#56179).

I think this requires the pull request for zalgo-promise to be merged first though, because parts of the API has ZalgoPromise types

@daniel-shuy
Copy link

@ispedals @types/zalgo-promise has been merged and released

@ispedals
Copy link

@daniel-shuy thanks. Created DefinitelyTyped/DefinitelyTyped#56897 to have the types included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants