Skip to content

Commit

Permalink
fix: lintable
Browse files Browse the repository at this point in the history
  • Loading branch information
westeezy committed Nov 22, 2022
1 parent 1408e01 commit e265eff
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 25 deletions.
6 changes: 2 additions & 4 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@ module.exports = {
extends:
"./node_modules/@krakenjs/eslint-config-grumbler/eslintrc-typescript",

globals: {
__TEST__: true,
},

rules: {
"keyword-spacing": "off",
"@typescript-eslint/keyword-spacing": "off",
},
};
30 changes: 17 additions & 13 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,22 +80,26 @@
],
"readmeFilename": "README.md",
"devDependencies": {
"@commitlint/cli": "^16.2.1",
"@commitlint/config-conventional": "^16.2.1",
"@krakenjs/grumbler-scripts": "^8.0.5",
"@vitest/ui": "^0.16.0",
"c8": "^7.11.0",
"chai": "^4.2.0",
"@commitlint/cli": "^17.3.0",
"@commitlint/config-conventional": "^17.3.0",
"@krakenjs/babel-config-grumbler": "^8.0.7",
"@krakenjs/eslint-config-grumbler": "^8.0.7",
"@krakenjs/typescript-config-grumbler": "^8.0.7",
"@krakenjs/webpack-config-grumbler": "^8.1.0-alpha.1",
"@vitest/coverage-c8": "^0.25.3",
"@vitest/ui": "^0.25.3",
"chai": "^4.3.7",
"cross-env": "^7.0.3",
"flowgen": "^1.16.0",
"happy-dom": "^2.55.0",
"husky": "^7.0.4",
"flowgen": "^1.20.1",
"happy-dom": "^7.7.0",
"husky": "^8.0.2",
"lint-staged": "^13.0.3",
"prettier": "2.7.1",
"standard-version": "^9.3.2",
"ts-node": "^10.5.0",
"typescript": "4.6.3",
"vitest": "0.16.0"
"standard-version": "^9.5.0",
"ts-node": "^10.9.1",
"typescript": "4.9.3",
"vite": "^3.2.4",
"vitest": "0.25.3"
},
"lint-staged": {
"**/*": "prettier --write --ignore-unknown"
Expand Down
1 change: 0 additions & 1 deletion src/util.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ export function isRegex(item: unknown): boolean {
return Object.prototype.toString.call(item) === "[object RegExp]";
}

// eslint-disable-next-line @typescript-eslint/no-unused-vars
export function noop(...args: ReadonlyArray<unknown>): void {
// pass
}
10 changes: 4 additions & 6 deletions src/utils.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
/* eslint max-lines: 0, @typescript-eslint/prefer-optional-chain: 0 */
/* global NodeJS */
import { isRegex, noop } from "./util";
import type {
CrossDomainWindowType,
SameDomainWindowType,
DomainMatcher,
import {
type CrossDomainWindowType,
type SameDomainWindowType,
type DomainMatcher,
} from "./types";
import { PROTOCOL, WILDCARD } from "./constants";

Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"extends": "@krakenjs/grumbler-scripts/config/tsconfig.json"
"extends": "@krakenjs/typescript-config-grumbler/tsconfig.json"
}

0 comments on commit e265eff

Please sign in to comment.