We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I noticed a couple of instances that would be nice to fix.
once definition doesn't return cancel function in its type. It should return
once
export function once( name: string, options?: ServerOptionsType | HandlerType, handler?: HandlerType, ): ZalgoPromise<{ source: any; origin: string; data: object }> & CancelableType;
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/post-robot/index.d.ts#L39-L43
HandlerType doesn't allow non-promise functions it should be both
HandlerType
type HandlerType = (event: { source: CrossDomainWindowType, origin: string, data: any }) => ZalgoPromise<any> | void;
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/post-robot/index.d.ts#L15-L19
I didn't go over all other definitions, I just noticed these two, there could be more issues.
The text was updated successfully, but these errors were encountered:
I can take this up, have been busy since I wrote the definitions couple of years ago. @mstuart
Thank you @malsabbagh for pointing these out :)
Sorry, something went wrong.
No branches or pull requests
I noticed a couple of instances that would be nice to fix.
once
definition doesn't return cancel function in its type. It should returnhttps://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/post-robot/index.d.ts#L39-L43
HandlerType
doesn't allow non-promise functions it should be bothhttps://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/post-robot/index.d.ts#L15-L19
I didn't go over all other definitions, I just noticed these two, there could be more issues.
The text was updated successfully, but these errors were encountered: