Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences between mesh generation on Win and linux result in fragile CI #129

Open
krcools opened this issue Apr 15, 2024 · 1 comment
Open

Comments

@krcools
Copy link
Owner

krcools commented Apr 15, 2024

In test/test_hh3d_nearfield, the spherical mesh generated by gmsh is different on WIndows and linux for the specific parameters passed to CompScienceMeshes.meshsphere. This can result in error bounds set in a Linux environment to be too tight for Windows.

It would be better to load mesh files from an asset subdirectory of test than to generate the mesh on every run. Not only is this more robust, it also results in fewer non-test related CPU time.

@sbadrian
Copy link
Contributor

sbadrian commented May 3, 2024

We got a student working on this topic.

I think the default behavior should change to the Julia code, but maybe we would like to retain the possibility to generate a sphere or cube mesh via GMSH? We could add a keyword argument to accommodate for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants