Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
* Example html * addOption.html * refactor (added no.kristiania.http package) * Main method @HttpServer hosts the html sites. Added HttpClient to be able to test server + a few test for client and server. 👍 * fixed autofix that happend somehow * Small changes to html to make them circle around. added question class (missing stuff still) * pom.xml update. implementing Dao with testdata (unfinished) * Flyway create questions table sql script * h2 works but flyway?? * Can add title and text manually through main method * Made HttpPostClient for post test shouldListInsertedQuestions🟠 Is green but lidl error * Added ListQuestionsController and AddQuestionController * Added OptionDao and options to question controllers * refactor (removed comments) * answers DB sql made * shouldReturnSavedAnswers 🟢 * Works on main 🟢 * Changed api/result to api/answer to match table name * test * Can add options to question manually * removed unused dao in controllers * Added Logger to HttpServer * Added test for /api/questions shouldFindQuestions 🟢 * ShouldListEditedQuestions 😡😡😡😡 IndexOutOfBoundException manually, but works in tests but dosnt update DB * ShouldListEditedQuestions 🟢 NB! Fails manually on site * Now works manually too!! * favicon 200 get but no icon? * sdfsdfasdf * testeteetett * changed favicon root to src/main/resources/ * it works??? * html edit * ShouldListAddedOptions 🟢 * shouldWriteOptionsOnQuestions 🟢 * shouldWriteEditQuestionsPage 🟢 * plant uml stuff * Cleaned up redundant imports, removed unnecessary space. Added logevents.properties and maven jar/shade plugins. * Added JANSI dependency, support for ANSI color codes * Updated README.md + minor refactors * 95% finished Sequence diagram, trenger noen notat blokker for noen ekstra detaljer * Added PK for Answers to improve the database NF and for future implementation 😎 * Updated README * lidl update * lidl update2 * Finished most stuff on readme * 2 sekvens diagram som viser hvordan programmet håndterer et eksempel på GET og POST * hot fix (i think) * smol fixes * better favicon 🐶 👍 * UML diagram corrections* * fixed* * shouldWriteResultPage 🟢 * shouldShowAmountOfTimeChoosen 🟢 * fixed * html formatting * html formatting in ListController classes * html text fix Co-authored-by: Sakelig <[email protected]>
time-out minutes: 3
* Example html * addOption.html * refactor (added no.kristiania.http package) * Main method @HttpServer hosts the html sites. Added HttpClient to be able to test server + a few test for client and server. 👍 * fixed autofix that happend somehow * Small changes to html to make them circle around. added question class (missing stuff still) * pom.xml update. implementing Dao with testdata (unfinished) * Flyway create questions table sql script * h2 works but flyway?? * Can add title and text manually through main method * Made HttpPostClient for post test shouldListInsertedQuestions🟠 Is green but lidl error * Added ListQuestionsController and AddQuestionController * Added OptionDao and options to question controllers * refactor (removed comments) * answers DB sql made * shouldReturnSavedAnswers 🟢 * Works on main 🟢 * Changed api/result to api/answer to match table name * test * Can add options to question manually * removed unused dao in controllers * Added Logger to HttpServer * Added test for /api/questions shouldFindQuestions 🟢 * ShouldListEditedQuestions 😡😡😡😡 IndexOutOfBoundException manually, but works in tests but dosnt update DB * ShouldListEditedQuestions 🟢 NB! Fails manually on site * Now works manually too!! * favicon 200 get but no icon? * sdfsdfasdf * testeteetett * changed favicon root to src/main/resources/ * it works??? * html edit * ShouldListAddedOptions 🟢 * shouldWriteOptionsOnQuestions 🟢 * shouldWriteEditQuestionsPage 🟢 * plant uml stuff * Cleaned up redundant imports, removed unnecessary space. Added logevents.properties and maven jar/shade plugins. * Added JANSI dependency, support for ANSI color codes * Updated README.md + minor refactors * 95% finished Sequence diagram, trenger noen notat blokker for noen ekstra detaljer * Added PK for Answers to improve the database NF and for future implementation 😎 * Updated README * lidl update * lidl update2 * Finished most stuff on readme * 2 sekvens diagram som viser hvordan programmet håndterer et eksempel på GET og POST * hot fix (i think) * smol fixes * better favicon 🐶 👍 * UML diagram corrections* * fixed* * shouldWriteResultPage 🟢 * shouldShowAmountOfTimeChoosen 🟢 * fixed * html formatting * html formatting in ListController classes * html text fix * Fixed favicon * Fixed favicon Co-authored-by: Sakelig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mastersince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `master` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `master`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.Subscribed: @willidachili