You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently Kruize Performance/Metric Profile and Recommendation engine is tightly coupled to support only container and namespace metric queries and correspondingly generate container and namespace recommendations. Similarly we might need separate queries for different workloads and supporting custom metrics would be helpful to generate custom recommendations based on the user JSON format which plugins into the Kruize RecommendationEngine.
Examples or references
The existing MetricProfile JSON has both container and namespace metric queries listed and while generating recommendations the metrics are filtered out based on the prefix (for eg. namespaceCpuRequest
namespace metrics are identified with prefix namespace). Instead of the bifurcation within the Java code, it would be helpful to have a generic abstraction in place to support different workloads based on the user requirements.
Suggest a solution
Have 1:1 correspondence with performance/metric profile YAML and /performanceProfiles/PerformanceProfileInterface/RemoteMonitoringOpenShiftImpl.java
Implement abstractions to bring together:
User input Performance/MetricProfile JSON with custom metrics
Java code to process the user specified metrics
Support user JSON format of recommendations which plugins into the RecommendationEngine and generates custom recommendations.
Helps to make the code modular
Also include tests which will test above 3 components together
Additional Context
None
The text was updated successfully, but these errors were encountered:
Describe the feature
Currently Kruize Performance/Metric Profile and Recommendation engine is tightly coupled to support only container and namespace metric queries and correspondingly generate container and namespace recommendations. Similarly we might need separate queries for different workloads and supporting custom metrics would be helpful to generate custom recommendations based on the user JSON format which plugins into the Kruize
RecommendationEngine
.Examples or references
The existing MetricProfile JSON has both container and namespace metric queries listed and while generating recommendations the metrics are filtered out based on the prefix (for eg.
namespaceCpuRequest
namespace metrics are identified with prefix
namespace
). Instead of the bifurcation within the Java code, it would be helpful to have a generic abstraction in place to support different workloads based on the user requirements.Suggest a solution
Have 1:1 correspondence with performance/metric profile YAML and
/performanceProfiles/PerformanceProfileInterface/RemoteMonitoringOpenShiftImpl.java
Implement abstractions to bring together:
Helps to make the code modular
Also include tests which will test above 3 components together
Additional Context
None
The text was updated successfully, but these errors were encountered: