Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database updates for authentication #1311

Merged
merged 10 commits into from
Nov 21, 2024
Merged

Conversation

khansaad
Copy link
Contributor

@khansaad khansaad commented Oct 3, 2024

Description

This PR adds database changes and related structural changes to save authentication in the DB.

Fixes # (issue)

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes

How has this been tested?

Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

  • New Test X
  • Functional testsuite

Test Configuration

  • Kubernetes clusters tested on: Testing is in progress on Openshift

Checklist 🎯

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

Include any additional information such as links, test results, screenshots here

@khansaad khansaad added the enhancement New feature or request label Oct 3, 2024
@khansaad khansaad added this to the Kruize 0.0.26 Release milestone Oct 3, 2024
@khansaad khansaad requested a review from msvinaykumar October 3, 2024 05:46
@khansaad khansaad self-assigned this Oct 3, 2024
@khansaad khansaad marked this pull request as ready for review October 15, 2024 07:50
@khansaad
Copy link
Contributor Author

Running the tests for the same, will update once successfully completed

Signed-off-by: Saad Khan <[email protected]>
Copy link
Contributor

@msvinaykumar msvinaykumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dinogun
Copy link
Contributor

dinogun commented Nov 21, 2024

@khansaad Please fix the conflicts

# Conflicts:
#	src/main/java/com/autotune/common/datasource/DataSourceCollection.java
#	src/main/java/com/autotune/utils/KruizeConstants.java
Signed-off-by: Saad Khan <[email protected]>
@khansaad
Copy link
Contributor Author

@khansaad Please fix the conflicts

Done

@dinogun dinogun merged commit 227769f into kruize:mvp_demo Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants