Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request for extract_from_video python binding. #10

Open
alik-git opened this issue Dec 3, 2024 · 3 comments
Open

Feature request for extract_from_video python binding. #10

alik-git opened this issue Dec 3, 2024 · 3 comments

Comments

@alik-git
Copy link
Contributor

alik-git commented Dec 3, 2024

Right now , if we have a krec file in an mkv container i.e. filename.krec.mkv., then to load the krec we have to do

krec_file_path = "path/to/name.krec" # path to temporarily place a .krec file
krec.extract_from_video(mkv_file_path, krec_file_path)
krec_obj = krec.KRec.load(krec_file_path)

This should be replaced by

krec_obj = krec.extract_from_video(mkv_file_path)
@alik-git
Copy link
Contributor Author

alik-git commented Dec 3, 2024

Also, calling this function also riggers a bunch of ffmpeg output in the terminal, this should be turned off by default. I suggest adding an argument verbose which is False by default.

@budzianowski
Copy link
Contributor

This is closed right?

@alik-git
Copy link
Contributor Author

alik-git commented Dec 6, 2024

done, should close soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants