Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Relax conditions for warning on updating converters
Allow sub/superclass without warning. This was motivated by Pandas, as they have several instances of the same class in the registry. We also had this internally, though resolved that by using the same instance for multiple registry entries rather than by relaxing the warning. This becomes impractical when dealing with downstream. It may have been sufficient to allow only identical types, but to be safe, decided to allow both sub- and superclass relationships. The purpose of the warning was that it gets overwritten without heeding prior data provided which would break in unexpected ways. The most common case for this is when one converter class operates on multiple data types, but separate instances of the class are in the registry. So while the previous data is compatible the equality check still failed. Requiring downstream to implement equality checks seems impractical. Additionally used both `is` and `==` for the earlier short circuit, which should in most cases be identical operations, but just in case.
- Loading branch information