Conditionally initalise worker state #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktec
force-pushed
the
ks/conditional_startup
branch
from
145af2e to
42fda99
Compare
ktec
force-pushed
the
ks/conditional_startup
branch
2 times, most recently
from
8d6f282 to
e750aa3
Compare
This commit updates the `Worker` `GenServer` so that the `handle_continue/2` callback is only invoked when the service is set to `DefaultService`. This module already knows about `DefaultService` so this seems slightly better than pattern matching on `MockService`, however if there are alternative "production" services, other than `DefaultService` the `Worker.init/1` would need to change. Because we are unable to call `handle_continue/2` directly from the `worker_test.ex` we need to add `initialise_foo/0` which finds the pid and sends the `:initialise_foo` message. This same message is also used in the `handle_continue/2` callback. The tests can be run using: ``` mix test ```
ktec
force-pushed
the
ks/conditional_startup
branch
from
e750aa3 to
2a44fea
Compare
ktec
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the
WorkerGenServerso that thehandle_continue/2callback is only invoked when the service is set toDefaultService.This module already knows about
DefaultServiceso this seems slightlybetter than pattern matching on
MockService, however if there arealternative "production" services, other than
DefaultServicetheWorker.init/1would need to change.Because we are unable to call
handle_continue/2directly from theworker_test.exwe need to addinitialise_foo/0which finds the pidand sends the
:initialise_foomessage. This same message is also usedin the
handle_continue/2callback.The tests can be run using: