Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase vuex-smart-module on vuex 5? #527

Open
nicolidin opened this issue Nov 16, 2021 · 2 comments
Open

Rebase vuex-smart-module on vuex 5? #527

nicolidin opened this issue Nov 16, 2021 · 2 comments

Comments

@nicolidin
Copy link

nicolidin commented Nov 16, 2021

Hey @ktsn

Vuex5 coming out soon!
What do you think of that?
It is based on Pinia that is not class based, and thus it can't allow splitting and move the logic in specific classes (for action, states etc.), these store "parts" can't be declared outside and then composed in a store instance.
Furthermore, Pinia does not have nested Store.
However, Pinia have some good too, especially about the return type of action, I'm almost sure it does not have the promise type and thus allows to return a specific type.

@nicolidin nicolidin changed the title Rebased vuex-smart-module on vuex 5? Rebase vuex-smart-module on vuex 5? Nov 16, 2021
@nicolidin
Copy link
Author

friendly ping @ktsn

@vdkrasny
Copy link
Contributor

vdkrasny commented Jul 17, 2022

This library solves the problem of weak vuex typing when working with TypeScript
Pinia supports TypeScript out of the box. So I assume that vuex 5 will also support it.
For example vuex 4 already does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants