Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all calls to eval in preparation for the eventual removal of the eval function #27

Open
roboguy13 opened this issue Jul 17, 2015 · 2 comments

Comments

@roboguy13
Copy link
Member

Currently, the only calls to eval are to use rule-to-lemma. eval is used here due to the pretty printer.

@ecaustin
Copy link
Contributor

ecaustin commented Aug 6, 2015

We should be able to modify scripts to now use getPP in order to call ruleToLemma directly.

However, my initial testing is showing that these functions still fail, but I believe it's due to the DocH return value and not because of the PrettyPrinter arguments.

@ecaustin
Copy link
Contributor

Commit 773e016 should have us ready for this.

As a heads up, we'll probably have to regenerate the golden output for some tests since we may change the output of scripts when moving away from eval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants