Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM] [rds-core] Add VFs to best effort pods #170

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[DNM] [rds-core] Add VFs to best effort pods #170

wants to merge 2 commits into from

Conversation

josecastillolema
Copy link
Contributor

@josecastillolema josecastillolema commented Jan 10, 2025 •
edited
Loading

Type of change

  • Optimization

Tests

oc get pod server-2-d7bc9dc5c-4smsh  -o json|grep -i sriov
            "k8s.v1.cni.cncf.io/network-status": "[{\n    \"name\": \"ovn-kubernetes\",\n    \"interface\": \"eth0\",\n    \"ips\": [\n        \"10.128.60.206\"\n    ],\n    \"mac\": \"0a:58:0a:80:3c:ce\",\n    \"default\": true,\n    \"dns\": {}\n},{\n    \"name\": \"rds-6/sriov-net-6-1\",\n    \"interface\": \"net1\",\n    \"ips\": [\n        \"10.1.54.0\"\n    ],\n    \"mac\": \"72:cb:29:cc:75:2d\",\n    \"mtu\": 1500,\n    \"dns\": {},\n    \"device-info\": {\n        \"type\": \"pci\",\n        \"version\": \"1.1.0\",\n        \"pci\": {\n            \"pci-address\": \"0000:62:0a.4\"\n        }\n    }\n}]",
            "k8s.v1.cni.cncf.io/networks": "[ { \"name\": \"sriov-net-6-1\" } ]",

Related Tickets & Documents

@josecastillolema josecastillolema requested review from a team as code owners January 10, 2025 12:14
@josecastillolema josecastillolema added the enhancement New feature or request label Jan 10, 2025
@vishnuchalla
Copy link
Contributor

Please sign the commits and check if there is a possibility to add some CI tests on these changes.

@josecastillolema
[rds-core] Add VFs to best effort pods
cb4a480 
Signed-off-by: Jose Castillo Lema <[email protected]>
@josecastillolema
Update number of VFs
eef9a94 
Signed-off-by: Jose Castillo Lema <[email protected]>
@josecastillolema
Copy link
Contributor Author

Please sign the commits and check if there is a possibility to add some CI tests on these changes.

Commits properly signed.
About the CI tests, I am unsure that the CI environment has proper support for SRIOV so it may not be possible.

@josecastillolema
Copy link
Contributor Author

@vishnuchalla looks like the linter is broken?

@vishnuchalla
Copy link
Contributor

@vishnuchalla looks like the linter is broken?

Should be fixed after this merge: #175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFE] [rds workload] Add SRIOV VFs to the best effort pods
2 participants
@josecastillolema @vishnuchalla